Small enhancements for collection builders #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmchilton
commented
Mar 22, 2017
jmchilton
commented
- Allow the use of the list and paired collection builders for non-terminal datasets (e.g. 'new', 'queued', etc...). This is needed ahead of collection uploading and the paired list builder already allowed it anyway.
- Add option to all collection builders to hide the original datasets. This is a common usage pattern - so we should support it. Should help mitigate certain problems caused by large histories.
- Extend API and API tests to support this new operation of hiding the original datasets.
- Extend test case coverage for collection builders and some work on general Selenium test improvements.
- Add simple test case for paired list creation.
- Add test cases for creating lists and paired lists when hiding the original datasets (new functionality in this PR).
- Add a new retry action decorator to certain Selenium operations to try to make testing more robust in general.
jmchilton
force-pushed
the
collection_builder_enhancements
branch
from
f56c8f4
to
759aa4b
Compare
This includes two parallel changes to the Selenium tests. - It adds a decorator to allow retrying certain atomic actions that may occur during jQuery transitions automatically. - It refactors things to allow waiting on HIDs to become visible instead of just green.
Reworks addition of staleness checkers introduced in galaxyproject#3780.
- Add test case for building paired lists. - Add tests for new hide original datasets functionality for lists and paired lists.
jmchilton
force-pushed
the
collection_builder_enhancements
branch
from
759aa4b
to
82ca693
Compare
|
thanks @jmchilton |
|
Awesome sauce - thanks for the merge and thanks for creating #3827. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.