Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small enhancements for collection builders #3806

Merged

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Mar 22, 2017

  • Allow the use of the list and paired collection builders for non-terminal datasets (e.g. 'new', 'queued', etc...). This is needed ahead of collection uploading and the paired list builder already allowed it anyway.
  • Add option to all collection builders to hide the original datasets. This is a common usage pattern - so we should support it. Should help mitigate certain problems caused by large histories.
  • Extend API and API tests to support this new operation of hiding the original datasets.
  • Extend test case coverage for collection builders and some work on general Selenium test improvements.
    • Add simple test case for paired list creation.
    • Add test cases for creating lists and paired lists when hiding the original datasets (new functionality in this PR).
    • Add a new retry action decorator to certain Selenium operations to try to make testing more robust in general.

jmchilton added some commits Mar 24, 2017

Allow non-ready jobs in collection builder.
This includes two parallel changes to the Selenium tests.

- It adds a decorator to allow retrying certain atomic actions that may occur during jQuery transitions automatically.
- It refactors things to allow waiting on HIDs to become visible instead of just green.
Fix transiently failing Selenium test of tool form re-running.
Reworks addition of staleness checkers introduced in #3780.
More test cases for collection builders.
- Add test case for building paired lists.
- Add tests for new hide original datasets functionality for lists and paired lists.

@jmchilton jmchilton force-pushed the jmchilton:collection_builder_enhancements branch from 759aa4b to 82ca693 Mar 24, 2017

@martenson

This comment has been minimized.

Copy link
Member

commented Mar 27, 2017

thanks @jmchilton
I found minor issue while testing (#3827) but this PR did not introduce it.

@martenson martenson merged commit db09acb into galaxyproject:dev Mar 27, 2017

0 of 5 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
toolshed test Test started.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2017

Awesome sauce - thanks for the merge and thanks for creating #3827.

@jmchilton jmchilton deleted the jmchilton:collection_builder_enhancements branch Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.