New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz plugin loading fixes #5081

Merged
merged 14 commits into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Nov 27, 2017

Fixes charts and scatterplot.

Refactors imports and exports used by external-to-client consumers to allow direct access (without generally requiring Blah.default access). Includes cleanup and minor fixes, removing some unused imports in various modules, etc.

Overhauls scatterplot to be a bundled plugin, using webpack instead of grunt/concat/etc.

@guerler It'd be worth perusing the bundling changes here with #4256 in mind. We could simplify the Galaxy/Viz interface and continue to plug bundles in pretty easily, I think (without mako!)

Fixes #5067

@dannon

This comment has been minimized.

Member

dannon commented Nov 29, 2017

Rebased and rebuilt.

@dannon

This comment has been minimized.

Member

dannon commented Nov 30, 2017

Rebased and rebuilt again.

@dannon

This comment has been minimized.

Member

dannon commented Dec 4, 2017

Rebased and rebuilt again.

@bgruening bgruening merged commit 8c87b2c into galaxyproject:dev Dec 4, 2017

7 checks passed

api test Build finished. 332 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 165 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 59 tests run, 0 skipped, 0 failed.
Details
lgtm analysis: JavaScript 2 new alerts
Details
selenium test Build finished. 117 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Member

bgruening commented Dec 4, 2017

@dannon thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment