Viz plugin loading fixes #5081
Merged
Viz plugin loading fixes #5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
added
area/UI-UX
area/visualizations
status/WIP
kind/bug
kind/enhancement
kind/refactoring
dannon
force-pushed
the
fix-charts-packing
branch
from
bbe4b33
to
9b1f354
Compare
|
Rebased and rebuilt. |
dannon
force-pushed
the
fix-charts-packing
branch
from
9b1f354
to
aef40a8
Compare
|
Rebased and rebuilt again. |
…e can expect external consumers of.
… the practice of re-exporting stuff, but that's another project that'll have to fix downstream consumers.
… to fix require-based entry. Lots of cleanup, too.
…erplot gruntfile.
…tip loading and it's good to go.
…, can easily be used as an import (we probably want to get rid of this stuff eventually, but it works for now)
…s there for utils)
dannon
force-pushed
the
fix-charts-packing
branch
from
aef40a8
to
50870d5
Compare
|
Rebased and rebuilt again. |
|
@dannon thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes charts and scatterplot.
Refactors imports and exports used by external-to-client consumers to allow direct access (without generally requiring Blah.default access). Includes cleanup and minor fixes, removing some unused imports in various modules, etc.
Overhauls scatterplot to be a bundled plugin, using webpack instead of grunt/concat/etc.
@guerler It'd be worth perusing the bundling changes here with #4256 in mind. We could simplify the Galaxy/Viz interface and continue to plug bundles in pretty easily, I think (without mako!)
Fixes #5067