Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sudo: false from .travis.yml, it will stop being supported soon #7035

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

martenson
Copy link
Member

@martenson martenson added kind/refactoring cleanup or refactoring of existing code, no functional changes area/testing labels Nov 21, 2018
@martenson martenson added this to the 19.01 milestone Nov 21, 2018
@martenson
Copy link
Member Author

this PR reliably fails on travis with

==================================== ERRORS ====================================
________________ ERROR collecting lib/galaxy/objectstore/s3.py _________________
lib/galaxy/objectstore/s3.py0m:31: in <module>
    from .s3_multipart_upload import multipart_upload
lib/galaxy/objectstore/s3_multipart_upload.py:17: in <module>
    import boto
.tox/py27-unit/lib/python2.7/site-packages/boto/__init__.py:1216: in <module>
    boto.plugin.load_plugins(config)
E   AttributeError: 'module' object has no attribute 'plugin'
________ ERROR collecting lib/galaxy/objectstore/s3_multipart_upload.py ________
lib/galaxy/objectstore/s3_multipart_upload.py:17: in <module>
    import boto
.tox/py27-unit/lib/python2.7/site-packages/boto/__init__.py:1216: in <module>
    boto.plugin.load_plugins(config)
E   AttributeError: 'module' object has no attribute 'plugin'
 generated html file: /home/travis/build/galaxyproject/galaxy/run_unit_tests.html 
=============================== warnings summary ===============================
/home/travis/build/galaxyproject/galaxy/.tox/py27-unit/lib/python2.7/site-packages/sqlalchemy/orm/relationships.py:2435: SAWarning: Non-simple column elements in primary join condition for property HistoryDatasetAssociation.visible_children - consider using remote() annotations to mark the remote side.
  % self.prop
/home/travis/build/galaxyproject/galaxy/.tox/py27-unit/lib/python2.7/site-packages/sqlalchemy/orm/relationships.py:2435: SAWarning: Non-simple column elements in primary join condition for property LibraryDatasetDatasetAssociation.visible_children - consider using remote() annotations to mark the remote side.
  % self.prop
-- Docs: https://docs.pytest.org/en/latest/warnings.html
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
===================== 2 warnings, 2 error in 15.47 seconds =====================
Testing complete. HTML report is in "run_unit_tests.html".
ERROR: InvocationError for command '/bin/bash run_tests.sh -u' (exited with code 2)
___________________________________ summary ____________________________________
ERROR:   py27-unit: commands failed

@nsoranzo nsoranzo changed the title remove sudo from travis, it will stop being supported soon Remove sudo: false from .travis.yml, it will stop being supported soon Nov 26, 2018
@nsoranzo
Copy link
Member

This workaround seems to fix it for BioBlend: nsoranzo/bioblend@e75122f , I'll push the same here once tests finish at https://travis-ci.org/nsoranzo/bioblend/builds/459807060.

@martenson martenson merged commit 015b854 into galaxyproject:dev Nov 26, 2018
@bgruening bgruening deleted the remove-sudo branch November 26, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants