Add mcool datatype and extend h5 tool output testing #7993
Conversation
lib/galaxy/tools/xsd/galaxy.xsd
Outdated
| @@ -1652,6 +1652,8 @@ module. | |||
| </xs:element> | |||
| <xs:element name="has_h5_keys" type="AssertHasH5Keys"> | |||
| </xs:element> | |||
| <xs:element name="contains_h5_keys" type="AssertContainsH5Keys"> | |||
There was a problem hiding this comment.
has_ and contains_ is for a user probably the same. Could we extend the current has_ functionality?
There was a problem hiding this comment.
I suppose so. I wanted to avoid needing to specify a large number of keys for complex h5 files, but given that this is only invoked for tests, I suppose test output can be controlled to keep this list reasonable.
There was a problem hiding this comment.
Also, do you mean altering the 'has_h5_keys' test? Doing so would definitely break any tests currently using it if they have groups in the h5 files.
There was a problem hiding this comment.
I was reading this as change has_h5_keys to not require a complete exact match. Which makes sense, "has" does not mean "has only".
There was a problem hiding this comment.
What @jxtx said is what I wanted to say :) Sorry.
Removed log statements from proxy.js Added space back to validation_hdf5.xml Changed Mcool class to inherit from Cool in binary.py
| >>> fname = get_test_fname('wiggle.wig') | ||
| >>> MCool().sniff(fname) | ||
| False | ||
| >>> fname = get_test_fname('biom2_sparse_otu_table_hdf5.biom2') |
There was a problem hiding this comment.
can we add here a cool test what will eval to False?
|
This PR was merged without a 'kind/' tag, please correct. |
bgruening
changed the title
This PR does two things.