Skip to content

Fix gxformat2 to .ga conversion if hide: true specified on output #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix gxformat2 to .ga conversion if hide: true specified on output #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gxformat2/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
'hide': {
'action_class': "HideDatasetAction",
'default': False,
'arguments': lambda x: x,
'arguments': lambda x: {},
},
'rename': {
'action_class': 'RenameDatasetAction',
Expand All @@ -46,7 +46,7 @@
'delete_intermediate_datasets': {
'action_class': 'DeleteIntermediatesAction',
'default': False,
'arguments': lambda x: x,
'arguments': lambda x: {},
},
'change_datatype': {
'action_class': 'ChangeDatatypeAction',
Expand Down
4 changes: 2 additions & 2 deletions tests/test_post_job_action_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ def test_post_job_action_to_native(wf_template):
expected_value = {'tags': 'tag'}
elif isinstance(default_value, bool):
action_value = 'true'
expected_value = True
expected_value = {}
workflow_yaml = wf_template.format(action=action_key, action_value=action_value)
native = to_native(workflow_yaml)
pja_class = POST_JOB_ACTIONS[action_key]['action_class']
expected_pja = {pja_class + 'out_file1': OrderedDict([
("output_name", "out_file1"),
("action_type", pja_class),
("action_arguments", expected_value or action_value),
("action_arguments", expected_value if expected_value is not None else action_value),
])}
expected_pja = json.dumps(expected_pja, sort_keys=True)
converted_pjas = json.dumps(native['steps']['1']['post_job_actions'], sort_keys=True)
Expand Down
Loading