Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behaviour between test cases and citations #182

Closed
hexylena opened this issue May 5, 2015 · 4 comments
Closed

Different behaviour between test cases and citations #182

hexylena opened this issue May 5, 2015 · 4 comments
Labels

Comments

@hexylena
Copy link
Member

hexylena commented May 5, 2015

An empty test block counts as a warning, whereas an empty citation block doesn't. I would expect consistent behaviour between the two of them, specifically that an empty test block would be downgraded to INFO. An empty test block, like an empty citation block, implies that we know they're supposed to be there, but don't have a test case added for one reason or another.

<tests>
</tests>
<citations>
</citations>

See #152 for related discussion

@peterjc
Copy link
Contributor

peterjc commented May 6, 2015

Best practice is to have both tests and citations, but I would prefer to be stricter about trying to get people to add tests.

@hexylena
Copy link
Member Author

hexylena commented May 6, 2015

Agreed, I would prefer to be stricter about adding tests than about adding citations.

However, there are cases when you don't have tests, and would like to indicate that. I see <tests></tests> the best way to indicate "I have no tests", like <citations></citations> is the best way to indicate "I have no citations"

E.g:

@peterjc
Copy link
Contributor

peterjc commented May 6, 2015

Why can't those three examples have tests? Even if they are "dummy" tests which do little more than verify that an output file was made.

@hexylena
Copy link
Member Author

hexylena commented May 6, 2015

That's a fair point. Fine, closing this issue.

@hexylena hexylena closed this as completed May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants