New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty tar-balls gracefully on old Python #187

Merged
merged 1 commit into from May 8, 2015

Conversation

Projects
None yet
2 participants
@peterjc
Copy link
Contributor

peterjc commented May 7, 2015

This is a workaround for http://bugs.python.org/issue6123 where older versions of Python fail to handle an empty tar-ball.

(I found this during re-factoring where an error elsewhere in the shed_upload logic was resulting in empty tar-balls being generated)

@peterjc peterjc force-pushed the peterjc:empty_tarball branch 2 times, most recently from b844da2 to 0cff45f May 7, 2015

@peterjc

This comment has been minimized.

Copy link
Contributor Author

peterjc commented May 8, 2015

(Updated to use Python 3 compatible exception syntax)

@peterjc peterjc force-pushed the peterjc:empty_tarball branch from 0cff45f to ee9182e May 8, 2015

jmchilton added a commit that referenced this pull request May 8, 2015

Merge pull request #187 from peterjc/empty_tarball
Handle empty tar-balls gracefully on old Python

@jmchilton jmchilton merged commit fd646fa into galaxyproject:master May 8, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented May 8, 2015

Awesome - thanks for the fix!

@peterjc peterjc deleted the peterjc:empty_tarball branch May 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment