Handle empty tar-balls gracefully on old Python #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjc
force-pushed
the
empty_tarball
branch
2 times, most recently
from
b844da2
to
0cff45f
Compare
|
(Updated to use Python 3 compatible exception syntax) |
jmchilton
added a commit
that referenced
this pull request
May 8, 2015
Handle empty tar-balls gracefully on old Python
|
Awesome - thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for http://bugs.python.org/issue6123 where older versions of Python fail to handle an empty tar-ball.
(I found this during re-factoring where an error elsewhere in the shed_upload logic was resulting in empty tar-balls being generated)