recursive shed_diff with directories not yet in Tool Shed #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this error condition would mean a recursive shed_diff would fail on repository not yet uploaded to the Tool Shed. It now prints an error message but continues. Resolves GitHub issue galaxyproject#201 TODO: Ensure that shed_diff on a single repository gives an error return code, e.g. $ planemo shed_diff ~/repositories/pico_galaxy/tools/seq_concatenate/ && echo "$? returned" Repository [seq_concatenate] does not exist in the targeted Tool Shed, can't do shed_diff 0 returned
| error("Repository [%s] does not exist in the targeted Tool Shed, can't do shed_diff" | ||
| % realized_repository.name) | ||
| # TODO - Should this return an error code which can be checked for in recursive mode? | ||
| return 0 |
There was a problem hiding this comment.
I feel like if you just return a non-zero value here the exit code would be handled correctly by the layers above this.
There was a problem hiding this comment.
This is the TODO, we need a clean way to signal to the recursive shed_diff that this error should be ignored (i.e. a warning to the terminal only), whereas in non-recursive mode it really is an error which should quit with a non-zero return code.
|
thank you @peterjc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this error condition would mean a recursive
planemo shed_diffwould fail on repository not yet uploaded to the Tool Shed. It now prints an error message but continues.Resolves GitHub issue #201
TODO: Ensure that shed_diff on a single repository gives an error return code, e.g.