New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xunit improvements #330

Merged
merged 4 commits into from Oct 16, 2015

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

erasche commented Oct 16, 2015

  • Refactors XUnit report templates into a single more generic template. (http://stackoverflow.com/a/9691131 good resource for what fields are available)
  • Unrelated mktemp -> mkstemp
  • Include timings in shed_diff (not useful but hey, neato)
  • Include diffs in shed_diff (hella useful)

erasche added some commits Oct 15, 2015

Remove old mktemp call
'In version 2.3 of Python, this module was overhauled for enhanced security. It now provides three new functions, NamedTemporaryFile(), mkstemp(), and mkdtemp(), which should eliminate all remaining need to use the insecure mktemp() function. Temporary file names created by this module no longer contain the process ID; instead a string of six random characters is used.'
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Oct 16, 2015

Super awesome @erasche.

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Oct 16, 2015

Nice!!!!
👍

Fix failed tests
- Removed time attribute to make deterministic
- Updated test case with diff output

@erasche erasche removed the tests missing label Oct 16, 2015

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Oct 16, 2015

Fixed test cases.

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented on tests/test_shed_diff.py in b564ca5 Oct 16, 2015

Hilarious, 👍.

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Oct 16, 2015

Thanks Eric.

martenson added a commit that referenced this pull request Oct 16, 2015

@martenson martenson merged commit 888a909 into master Oct 16, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erasche erasche deleted the xunit-improvements branch Oct 20, 2015

@erasche erasche referenced this pull request Oct 29, 2015

Merged

Add command to check_urls #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment