Lint extra #350
Lint extra #350
Conversation
| conditional_selects = tool_xml.findall("./inputs//conditional") | ||
| for conditional in conditional_selects: | ||
| select = conditional.find('./param[@type="select"]') | ||
| # Should conditionals ever not have a select? |
There was a problem hiding this comment.
It can have a boolean. According to https://github.com/galaxy-iuc/standards/blob/master/docs/best_practices/tool_xml.rst#booleans we do not recommend to use booleans for a conditional but it is possible.
There was a problem hiding this comment.
interesting. Thanks for that, I'll update it accordingly
|
Comments addressed. |
| 'command', | ||
| 'inputs', | ||
| 'request_param_translation', | ||
| 'uihints', |
There was a problem hiding this comment.
Are uihints even respected for data source tools? Hmm... we can revisit that later though.
Can you add macros and configfiles back in the same order as normal tools?
There was a problem hiding this comment.
That's an awful good question regarding uihints.
Yes, sorry, I removed everything I didn't see during very brief greps through the tools directory.
|
Good changes, I'll just create an issue to add tests after it is merged. |
|
@jmchilton okay, sounds good. Thanks for being lenient :) |
|
I'm going to merge this then - we will figure out Travis again someday I guess. |
Whoops. Forgot to open the PR. Should close out some old issues.
little to no motivation to add tests ... so ... yeah.