New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint extra #350

Merged
merged 9 commits into from Oct 27, 2015

Conversation

Projects
None yet
4 participants
@erasche
Copy link
Member

erasche commented Oct 27, 2015

Whoops. Forgot to open the PR. Should close out some old issues.

little to no motivation to add tests ... so ... yeah.

conditional_selects = tool_xml.findall("./inputs//conditional")
for conditional in conditional_selects:
select = conditional.find('./param[@type="select"]')
# Should conditionals ever not have a select?

This comment has been minimized.

@bgruening

bgruening Oct 27, 2015

Member

It can have a boolean. According to https://github.com/galaxy-iuc/standards/blob/master/docs/best_practices/tool_xml.rst#booleans we do not recommend to use booleans for a conditional but it is possible.

This comment has been minimized.

@erasche

erasche Oct 27, 2015

Author Member

interesting. Thanks for that, I'll update it accordingly

continue

select_options = select.findall('./option[@value]')
select_option_ids = [option.attrib['value'] for option in select_options]

This comment has been minimized.

@nsoranzo

nsoranzo Oct 27, 2015

Member

Maybe here it would be good to call lint_ctx.error() if the <option> has no value attribute.

select_options = select.findall('./option[@value]')
select_option_ids = [option.attrib['value'] for option in select_options]
whens = conditional.findall('./when')
when_ids = [when.attrib['value'] for when in whens]

This comment has been minimized.

@nsoranzo

nsoranzo Oct 27, 2015

Member

Maybe here it would be good to call lint_ctx.error() if the <when> has no value attribute.

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Oct 27, 2015

Comments addressed.

'command',
'inputs',
'request_param_translation',
'uihints',

This comment has been minimized.

@jmchilton

jmchilton Oct 27, 2015

Member

Are uihints even respected for data source tools? Hmm... we can revisit that later though.

Can you add macros and configfiles back in the same order as normal tools?

This comment has been minimized.

@erasche

erasche Oct 27, 2015

Author Member

That's an awful good question regarding uihints.

Yes, sorry, I removed everything I didn't see during very brief greps through the tools directory.

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Oct 27, 2015

Good changes, I'll just create an issue to add tests after it is merged.

@erasche

This comment has been minimized.

Copy link
Member Author

erasche commented Oct 27, 2015

@jmchilton okay, sounds good. Thanks for being lenient :)

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Oct 27, 2015

I'm going to merge this then - we will figure out Travis again someday I guess.

jmchilton added a commit that referenced this pull request Oct 27, 2015

@jmchilton jmchilton merged commit 088572a into master Oct 27, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@jmchilton jmchilton deleted the lint-extra branch Oct 27, 2015

This was referenced Oct 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment