Bwa read group fixes #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$rg.ID, etc... are not evaluated in when inside a string. Whole thing has whitespace in the end so it probably should be quoted.
If something is getting sanitized inproperly - we need to isolate that, document it, and treat it properly in a more specific block.
|
👍 |
|
👍 on the rest! |
|
@nsoranzo I agree the bwa wrapper should be brought more inline with the bwa-mem wrapper - in this and many other ways - but that seems less urgent to me than fixing the immediate bugs. How about we merge this and I create an issue to track that project? |
|
@jmchilton Sure! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.