-
-
Notifications
You must be signed in to change notification settings - Fork 127
Include xcode/ios platform selection in docs #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Include newly required xcode/ios platform selection.
WalkthroughAdds a “Select Xcode” step to the documented GitHub Actions workflow for iOS release, switching to Xcode 16.4 and downloading the iOS platform. The step is positioned after “Download iOS Artifact” and before “Fix File Permissions and Run fastlane.” No API or public entity changes. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Xcode as Xcode 16.4
participant Fastlane as fastlane
Dev->>GH: Trigger "Release to the App Store" workflow
GH->>GH: Download iOS Artifact
GH->>Xcode: xcode-select --switch /Applications/Xcode_16.4.app
GH->>Xcode: xcodebuild -downloadPlatform iOS
GH->>GH: Fix File Permissions
GH->>Fastlane: Run fastlane for build/sign/release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/03-github/06-deployment/ios.mdx (2)
456-461
: Update download-artifact to v4 for parity and fixesYou’re uploading with
actions/upload-artifact@v4
above; switch the download action tov4
as well for consistency and to benefit from recent fixes.- - name: Download iOS Artifact - uses: actions/download-artifact@v3 + - name: Download iOS Artifact + uses: actions/download-artifact@v4 with: name: build-iOS path: build/iOS
462-466
: Use setup-xcode & pin macOS 15 runner for Xcode 16.4Hard-coding
/Applications/Xcode_16.4.app
can break when GitHub’s macOS images rotate. Prefer using the official setup action and explicitly targeting the macOS 15 image that ships Xcode 16.4.• In docs/03-github/06-deployment/ios.mdx (around lines 462–466), replace the hardcoded switch step:
- - name: Select Xcode - run: | - sudo xcode-select --switch /Applications/Xcode_16.4.app - xcodebuild -downloadPlatform iOS + - name: Set up Xcode 16.4 + uses: apple-actions/setup-xcode@v1 + with: + xcode-version: '16.4' + - name: Download iOS platform support + run: xcodebuild -downloadPlatform iOS• Make sure your workflow job is pinned to
runs-on: macos-15
(ormacos-15-arm64
for ARM) so that Xcode 16.4 is guaranteed present.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/03-github/06-deployment/ios.mdx
(1 hunks)
Include newly required xcode/ios platform selection.
Changes
Checklist
code of conduct
Summary by CodeRabbit