Skip to content

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Mar 13, 2022

Changes

  • Introduce Lefthook (reference)
  • Remove Husky and Lint-staged (reduce the number of dependencies by 30 dependencies)
  • Update hooks to not do unnecessary work
  • make them executable
  • Ignore lib; jest was taking mocks from there.
  • Ignore dist in hooks (was taking some time to process large dist files)
  • Remove extreme checks from pre-commit hook
    • only related tests will be run)
    • only changed files checked against code styles.
  • Make cross-platform compatible
  • Fail when something gets logged to console in tests (use jest.spyOn instead)
  • Correct any some tests that assume some tools are installed on local machines

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)
  • Check that this works on Windows (Powershell 7 or WSL)
  • Check that this works on MacOS
  • Check that this works on Linux

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #357 (cb3ba56) into main (9440c54) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   44.65%   44.79%   +0.14%     
==========================================
  Files          51       51              
  Lines        1496     1498       +2     
  Branches      233      234       +1     
==========================================
+ Hits          668      671       +3     
+ Misses        824      823       -1     
  Partials        4        4              
Impacted Files Coverage Δ
src/model/build-parameters.ts 89.74% <ø> (ø)
src/model/input-readers/git-repo.ts 66.66% <ø> (ø)
src/model/input.ts 85.48% <100.00%> (ø)
src/model/system.ts 86.84% <100.00%> (+3.50%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants