Skip to content

Conversation

Philipp-M
Copy link
Contributor

Changes

#310 accidentally removed support for gitPrivateToken

This PR should fix this again.
Also transitive ssh://git@github.com url substition did not work for me which is the reason for the change in dist/platforms/ubuntu/steps/set_gitcredential.sh

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Cat Gif

@webbertakken
Copy link
Member

Thank you very much for also providing the fix! Looks good for me.
Can you confirm that this works?

@Philipp-M
Copy link
Contributor Author

Yes, I tested this way too long actully :)

@codecov-commenter
Copy link

Codecov Report

Merging #377 (c034ac6) into main (40891d6) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head c034ac6 differs from pull request most recent head a2ee3c1. Consider uploading reports for the commit a2ee3c1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   44.98%   44.92%   -0.07%     
==========================================
  Files          51       51              
  Lines        1485     1487       +2     
  Branches      230      259      +29     
==========================================
  Hits          668      668              
+ Misses        813      779      -34     
- Partials        4       40      +36     
Impacted Files Coverage Δ
src/model/docker.ts 17.24% <0.00%> (-1.28%) ⬇️
src/model/input.ts 85.48% <0.00%> (ø)
src/model/system.ts 86.84% <0.00%> (ø)
src/model/image-tag.ts 49.42% <0.00%> (ø)
src/model/cloud-runner/aws/index.ts 17.50% <0.00%> (ø)
src/model/cloud-runner/k8s/index.ts 11.34% <0.00%> (ø)
src/model/image-environment-factory.ts 11.11% <0.00%> (ø)
src/model/cloud-runner/aws/aws-error.ts 36.36% <0.00%> (ø)
src/model/cloud-runner/aws/aws-job-stack.ts 9.52% <0.00%> (ø)
... and 8 more

@webbertakken webbertakken merged commit 2b399b2 into game-ci:main Apr 5, 2022
@webbertakken
Copy link
Member

Released in v2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants