Skip to content

Conversation

frostebite
Copy link
Member

Changes

  • ...

Related Issues

  • ...

Related PRs

  • ...

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.

  • ...

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

coderabbitai bot commented Sep 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cloud-runner-develop-rclone

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

github-actions bot commented Sep 8, 2025

Cat Gif

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 22.22222% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.58%. Comparing base (98963da) to head (4b70ee0).
⚠️ Report is 1 commits behind head on cloud-runner-develop.

Files with missing lines Patch % Lines
...d-runner/services/core/shared-workspace-locking.ts 6.38% 42 Missing and 2 partials ⚠️
src/model/cloud-runner/providers/local/index.ts 0.00% 4 Missing and 1 partial ⚠️
src/model/cloud-runner/remote-client/index.ts 0.00% 4 Missing ⚠️
...loud-runner/providers/aws/services/task-service.ts 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           cloud-runner-develop     #732      +/-   ##
========================================================
- Coverage                 36.79%   36.58%   -0.22%     
========================================================
  Files                        79       79              
  Lines                      3424     3488      +64     
  Branches                    736      767      +31     
========================================================
+ Hits                       1260     1276      +16     
- Misses                     2004     2048      +44     
- Partials                    160      164       +4     
Files with missing lines Coverage Δ
src/model/build-parameters.ts 90.00% <ø> (ø)
...model/cloud-runner/options/cloud-runner-options.ts 91.30% <100.00%> (+0.25%) ⬆️
...ud-runner/services/hooks/container-hook-service.ts 75.75% <100.00%> (+2.13%) ⬆️
...loud-runner/workflows/build-automation-workflow.ts 10.44% <ø> (ø)
...loud-runner/providers/aws/services/task-service.ts 9.67% <25.00%> (+0.51%) ⬆️
src/model/cloud-runner/remote-client/index.ts 8.19% <0.00%> (-0.14%) ⬇️
src/model/cloud-runner/providers/local/index.ts 13.04% <0.00%> (-3.63%) ⬇️
...d-runner/services/core/shared-workspace-locking.ts 4.52% <6.38%> (+0.67%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frostebite frostebite marked this pull request as ready for review September 9, 2025 20:25
@frostebite frostebite merged commit bd1be2e into cloud-runner-develop Sep 9, 2025
80 of 82 checks passed
@frostebite frostebite deleted the cloud-runner-develop-rclone branch September 9, 2025 20:25
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +151 to +156
if [ -d "$GITHUB_WORKSPACE/.git" ]; then
echo "Ensuring Git LFS content is pulled"
(cd "$GITHUB_WORKSPACE" \
&& git lfs install || true \
&& git config --global filter.lfs.smudge "git-lfs smudge -- %f" \
&& git config --global filter.lfs.process "git-lfs filter-process" \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Guard Git LFS setup when git is missing

The new local‑docker setup block invokes git config --global … unconditionally. In environments where the container image does not include Git (a common case outside of the AWS/K8s providers), git config exits with 127 and the whole build script aborts before the Unity steps run. Unlike the surrounding git lfs install and git lfs pull calls, the git config commands are not wrapped in || true or guarded with command -v git, so the retry semantics you added for missing Git LFS don’t apply. Consider skipping the entire block when git (or git lfs) is unavailable, or make the config commands non‑fatal so local‑docker builds without Git still succeed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant