-
-
Notifications
You must be signed in to change notification settings - Fork 290
Cloud runner develop rclone #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ost:4566 for all; rely on k3d host mapping
…ost:4566 for all; rely on k3d host mapping
…ost:4566 for all; rely on k3d host mapping
…ost:4566 for all; rely on k3d host mapping
…ost:4566 for all; rely on k3d host mapping
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ost:4566 for all; rely on k3d host mapping
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## cloud-runner-develop #732 +/- ##
========================================================
- Coverage 36.79% 36.58% -0.22%
========================================================
Files 79 79
Lines 3424 3488 +64
Branches 736 767 +31
========================================================
+ Hits 1260 1276 +16
- Misses 2004 2048 +44
- Partials 160 164 +4
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments
to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
if [ -d "$GITHUB_WORKSPACE/.git" ]; then | ||
echo "Ensuring Git LFS content is pulled" | ||
(cd "$GITHUB_WORKSPACE" \ | ||
&& git lfs install || true \ | ||
&& git config --global filter.lfs.smudge "git-lfs smudge -- %f" \ | ||
&& git config --global filter.lfs.process "git-lfs filter-process" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Guard Git LFS setup when git
is missing
The new local‑docker setup block invokes git config --global …
unconditionally. In environments where the container image does not include Git (a common case outside of the AWS/K8s providers), git config
exits with 127 and the whole build script aborts before the Unity steps run. Unlike the surrounding git lfs install
and git lfs pull
calls, the git config
commands are not wrapped in || true
or guarded with command -v git
, so the retry semantics you added for missing Git LFS don’t apply. Consider skipping the entire block when git
(or git lfs
) is unavailable, or make the config commands non‑fatal so local‑docker builds without Git still succeed.
Useful? React with 👍 / 👎.
Changes
Related Issues
Related PRs
Successful Workflow Run Link
PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.
Checklist
code of conduct
in the documentation repo)