-
-
Notifications
You must be signed in to change notification settings - Fork 294
Fix build profile name truncation on Windows #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds optional Build Profile support to macOS and Windows GitHub Actions workflows by extending matrix entries, passing matrix.buildProfile to the build step, and conditionally appending “With Build Profile” to artifact names. Introduces two Unity asset meta files for sample macOS and Windows Build Profiles. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GA as GitHub Actions (Workflow)
participant MX as Matrix
participant UB as unity-builder (Build Step)
participant AR as Artifact Upload
Dev->>GA: Push/PR triggers workflow
GA->>MX: Expand matrix (platform, unityVersion, optional buildProfile)
loop For each matrix job
MX->>UB: Run build with inputs<br/>platform, unityVersion, buildProfile?
note over UB: If buildProfile present,<br/>pass it to builder
UB-->>GA: Build result (success/failure)
GA->>AR: Upload artifact<br/>name += " With Build Profile" if buildProfile
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2024-12-05T17:12:46.110Z
Applied to files:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 38.34% 38.34%
=======================================
Files 78 78
Lines 3169 3169
Branches 663 663
=======================================
Hits 1215 1215
Misses 1809 1809
Partials 145 145 🚀 New features to boost your workflow:
|
Changes
Related Issues
Related PRs
Successful Workflow Run Link
Checklist
code of conduct
in the documentation repo)
Notes
Summary by CodeRabbit
New Features
Chores