Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of GTIMetaData #5026

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Introduction of GTIMetaData #5026

merged 2 commits into from
Jan 20, 2024

Conversation

cgalelli
Copy link
Contributor

this pull request adds a very minimal implementation of the GTIMetaData class for storing the reference time of the GTI table.

Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
Signed-off-by: cgalelli <claudio.galelli@obspm.fr>

Signed-off-by: cgalelli <claudio.galelli@obspm.fr>
@cgalelli cgalelli added this to the 1.2 milestone Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9faaff3) 75.71% compared to head (f6b685f) 75.71%.
Report is 14 commits behind head on main.

Files Patch % Lines
gammapy/data/metadata.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5026   +/-   ##
=======================================
  Coverage   75.71%   75.71%           
=======================================
  Files         229      229           
  Lines       33845    33855   +10     
=======================================
+ Hits        25625    25633    +8     
- Misses       8220     8222    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cgalelli . This looks good to me!

@registerrier registerrier merged commit ecf6e7f into gammapy:main Jan 20, 2024
14 of 16 checks passed
@registerrier registerrier mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants