Add configurable graphite path. Fixes issue 87 #99

Merged
merged 3 commits into from Apr 11, 2013

Conversation

Projects
None yet
3 participants
@djosephsen
Contributor

djosephsen commented Apr 10, 2013

Deprecate the "graphite_prefix" attribute in favor of "graphite_path"
which is configurable via macros (%s %m %h). Sane defaults ensure that
existing configurations are not broken by this change. This should solve
issue 87 and any future needs in its general direction. I've moved code
relating to graphite and memcached from rrdhelpers.(c|h), to
export_helpers. This is housekeeping that reflects how those features
should have been implemented in my original graphite patch.

Dave Josephsen
Add configurable graphite path. Fixes issue 87
Deprecate the "graphite_prefix" attribute in favor of "graphite_path"
which is configurable via macros (%s %m %h). Sane defaults ensure that
existing configurations are not broken by this change. This should solve
issue 87 and any future needs in its general direction. I've moved code
relating to graphite and memcached from rrdhelpers.(c|h), to
export_helpers. This is housekeeping that reflects how those features
should have been implemented in my original ganglia patch.
@vvuksan

This comment has been minimized.

Show comment
Hide comment
@vvuksan

vvuksan Apr 10, 2013

Member

Dave,

looks like you undid the memcached patch. Can you take a look.

Member

vvuksan commented Apr 10, 2013

Dave,

looks like you undid the memcached patch. Can you take a look.

@djosephsen

This comment has been minimized.

Show comment
Hide comment
@djosephsen

djosephsen Apr 10, 2013

Contributor

yeah my bad. I'll fix it today

Contributor

djosephsen commented Apr 10, 2013

yeah my bad. I'll fix it today

@djosephsen

This comment has been minimized.

Show comment
Hide comment
@djosephsen

djosephsen Apr 11, 2013

Contributor

yay. happy travis

Contributor

djosephsen commented Apr 11, 2013

yay. happy travis

jbuchbinder added a commit that referenced this pull request Apr 11, 2013

Merge pull request #99 from djosephsen/graphite_path
Add configurable graphite path. Fixes issue 87

@jbuchbinder jbuchbinder merged commit ea358bf into ganglia:master Apr 11, 2013

1 check passed

default The Travis build passed
Details

@djosephsen djosephsen deleted the djosephsen:graphite_path branch Apr 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment