Add configurable graphite path. Fixes issue 87 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the "graphite_prefix" attribute in favor of "graphite_path" which is configurable via macros (%s %m %h). Sane defaults ensure that existing configurations are not broken by this change. This should solve issue 87 and any future needs in its general direction. I've moved code relating to graphite and memcached from rrdhelpers.(c|h), to export_helpers. This is housekeeping that reflects how those features should have been implemented in my original ganglia patch.
|
Dave, looks like you undid the memcached patch. Can you take a look. |
|
yeah my bad. I'll fix it today |
|
yay. happy travis |
jbuchbinder
added a commit
that referenced
this pull request
Apr 11, 2013
Add configurable graphite path. Fixes issue 87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the "graphite_prefix" attribute in favor of "graphite_path"
which is configurable via macros (%s %m %h). Sane defaults ensure that
existing configurations are not broken by this change. This should solve
issue 87 and any future needs in its general direction. I've moved code
relating to graphite and memcached from rrdhelpers.(c|h), to
export_helpers. This is housekeeping that reflects how those features
should have been implemented in my original graphite patch.