Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sonatype Lift config #258

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Added Sonatype Lift config #258

merged 2 commits into from
Aug 16, 2022

Conversation

freemanjp
Copy link
Member

Static analysis.

Static analysis.
@@ -0,0 +1,2 @@
build = "mvn"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lift Configuration Added: Key: build

New value: mvn


Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@@ -0,0 +1,2 @@
build = "mvn"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lift Configuration Added: Key: jdkVersion

New value: 11


Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #258 (91b658e) into master (89a98f0) will not change coverage.
The diff coverage is n/a.

❗ Current head 91b658e differs from pull request most recent head 5fb1fe0. Consider uploading reports for the commit 5fb1fe0 to get more accurate results

@@             Coverage Diff             @@
##              master      #258   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       136       136           
===========================================
  Files             70        70           
  Lines            656       656           
  Branches          33        33           
===========================================
  Hits             656       656           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@freemanjp freemanjp merged commit 0651d5d into master Aug 16, 2022
@freemanjp freemanjp deleted the lift branch August 16, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant