Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failure SimplifiedFpGroup #2911

Closed
simpcomp-team opened this issue Oct 10, 2018 · 1 comment · Fixed by #2917
Closed

Assertion failure SimplifiedFpGroup #2911

simpcomp-team opened this issue Oct 10, 2018 · 1 comment · Fixed by #2917

Comments

@simpcomp-team
Copy link

Using SimplifiedFpGroup the following assertion error occurs with assertion level 2.

Observed behaviour

gap> SetAssertionLevel(2);
gap> g:=FreeGroup("a");
<free group on the generators [ a ]>
gap> gens:=GeneratorsOfGroup(g);
[ a ]
gap> rels:=[gens[1]];
[ a ]
gap> G:=g/rels;
<fp group on the generators [ a ]>
gap> SimplifiedFpGroup(G);
Error, Assertion failure in
  Assert( 2, ForAll( imgs, function ( x )
        return x in H;
    end ) ); at /home/jspreer/GAP/gap-repository/lib/ghom.gi:309 called from 
GroupGeneralMappingByImagesNC( G, H, gens, imgs 
 ) at /home/jspreer/GAP/gap-repository/lib/ghom.gi:439 called from
GroupHomomorphismByImagesNC( G, H, GeneratorsOfGroup( G ), 
 List( TzImagesOldGens( T ), function ( i )
        return MappedWord( i, GeneratorsOfPresentation( T ), 
           GeneratorsOfGroup( H ) );
    end ) ) at /home/jspreer/GAP/gap-repository/lib/tietze.gi:1214 called from
<function "SimplifiedFpGroup">( <arguments> )
 called from read-eval loop at *stdin*:6
you may 'return;'
brk> 

Expected behaviour

Should return trivial group (fp group with 0 generators).

GAP banner and loaded packages

GAP loaded with option -r.

 ┌───────┐   GAP 4.10dev-1285-g44f1a0c of today
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-pc-linux-gnu-default64-kv5
 Configuration:  gmp 6.1.0, GASMAN, readline
 Loading the library and packages ...
 Packages:   AClib 1.3, Alnuth 3.1.0, AtlasRep 1.5.1, AutoDoc 2018.09.20, 
             AutPGrp 1.10, Browse 1.8.8, Carat 2.2.2, CRISP 1.4.4, 
             Cryst 4.1.17, CrystCat 1.1.8, CTblLib 1.2.2, FactInt 1.6.2, 
             FGA 1.4.0, GAPDoc 1.6.1, IO 4.5.4, IRREDSOL 1.4, LAGUNA 3.9.0, 
             Polenta 1.3.8, Polycyclic 2.14, PrimGrp 3.3.1, RadiRoot 2.8, 
             ResClasses 4.7.1, SmallGrp 1.3, Sophus 1.24, SpinSym 1.5, 
             TomLib 1.2.6, TransGrp 2.0.4, utils 0.58
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
@olexandr-konovalov
Copy link
Member

Thanks. This issue comes from simpcomp-team/simpcomp#10. I can reproduce this with a fresh pull from the stable-4.10 branch.

hulpke added a commit to hulpke/gap that referenced this issue Oct 11, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes gap-system#2911
hulpke added a commit to hulpke/gap that referenced this issue Oct 12, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes gap-system#2911
hulpke added a commit to hulpke/gap that referenced this issue Oct 15, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes gap-system#2911
hulpke added a commit to hulpke/gap that referenced this issue Oct 15, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes gap-system#2911
hulpke added a commit to hulpke/gap that referenced this issue Oct 19, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes gap-system#2911
fingolfin pushed a commit that referenced this issue Oct 25, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes #2911
fingolfin pushed a commit that referenced this issue Oct 25, 2018
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes #2911
ssiccha pushed a commit to ssiccha/gap that referenced this issue Mar 27, 2019
- Avoid code duplication between isomorphism and group method.
- Resolve issue with calling MappedWord on empty generator set.
- Added tests for simplification

This fixes gap-system#2911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants