-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot compute FrattiniSubgroup for G=PerfectGroup(1344,2) but can compute for SmallGroup(IdGroup(G)) #980
Comments
and it works. |
@hulpke Ah, very nice, thank you! I must have missed this in the manual. I wonder, though, why they are not represented as permutation groups by default.... |
Presentations are the "native" format of the library (as it was published in the book by Plesken and Holt. Reasons include:
Because of this the person who implemented the GAP library decided to stick with presentations as the default format, though they are not the best way of working with the groups on the computer. |
@hulpke Thank you for this information. It is in fact very interesting. I went back to check the manual and saw that the last sentence (just before 50.8-1 SizesPerfectGroups) says that all groups are represented as fp-groups instead of permutation groups, and there is also a comment about computational time. Would it be possible to include your points above into this part of the manual? I think it would be interesting/helpful. Also, in 50.8-2 PerfectGroup it does not say that the default filter is I am happy to do a PR on this if you prefer. Thanks. |
Only call these methods if `CanComputeFittingFree` is set. This will be set for perm and pc groups, as well as if HasFittingFreeLiftSetup is set. Add some fallback methods. This fixes gap-system#980
Only call these methods if `CanComputeFittingFree` is set. This will be set for perm and pc groups, as well as if HasFittingFreeLiftSetup is set. Add some fallback methods. Finiteness test fallback for lattice This fixes gap-system#980
Only call these methods if `CanComputeFittingFree` is set. This will be set for perm and pc groups, as well as if HasFittingFreeLiftSetup is set. Add some fallback methods. Finiteness test fallback for lattice This fixes gap-system#980
@hungaborhorvath adding a comment as to what the default filter is sounds like a good idea, feel free to open a PR. As to the computational speed, I am not so sure; after all, this is relevant to virtually all algorithms in computational group theory. Discussing it in one particular spot seems arbitrary. Finally, what should be done with this issue now? I see three options:
|
This is fixed in #968 (by having Fp groups etc. use more generic methods). |
GAP cannot compute the
FrattiniSubgroup
ofPerfectGroup(1344,2)
(errors out with no method found), but can if it is defined as a small group.Same happens with perfect groups 1920.4, 1920.5, 1920.6, 1920.7.
The text was updated successfully, but these errors were encountered: