gac: emit semicolon after all CHECK_* calls; turn CHECK_{BOOL,FUNC} into functions #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
do not merge
fingolfin
force-pushed
the
mh/tweak-gac-macros
branch
from
f5c21c5
to
bcd32ce
Compare
fingolfin
removed
the
do not merge
fingolfin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3419 +/- ##
==========================================
- Coverage 85.42% 85.2% -0.23%
==========================================
Files 697 699 +2
Lines 342456 344344 +1888
==========================================
+ Hits 292547 293395 +848
- Misses 49909 50949 +1040
|
ChrisJefferson
approved these changes
Apr 27, 2019
|
I'll close this, and merge #3419 , which contains it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation for this is to ensure sensible error message in gac compiled code which match those produced by the interpreter and coder. A new test verifies this for
CHECK_BOOL.I was planning to add a similar test for
CHECK_FUNC, but that revealed bugs in gac related to that, so that test along with a fix will be in a separate PR.