Improve gac to support calls to custom function objects #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
Previously, gac only supported functions calls using the `f()` syntax for internal functions, i.e., objects of type T_FUNCTION. But GAP allows custom functions, meaning that one can install methods that allow "calling" almost arbitrary objects. This commit adds this functionality to gac, too, so that it matches the interpreter and executor.
fingolfin
force-pushed
the
mh/gac-callfunc
branch
from
ad4106a
to
d58e31e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3423 +/- ##
==========================================
- Coverage 85.42% 85.16% -0.27%
==========================================
Files 697 697
Lines 342456 343878 +1422
==========================================
+ Hits 292547 292860 +313
- Misses 49909 51018 +1109
|
ChrisJefferson
approved these changes
Apr 27, 2019
fingolfin
changed the title
fingolfin
changed the title
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, gac only supported functions calls using the
f()syntax for internal functions, i.e., objects of typeT_FUNCTION. But GAP allows custom functions, meaning that one can install methods that allow "calling" almost arbitrary objects.This commit adds this functionality to gac, too, so that it matches the interpreter and executor.
This PR contains PR #3419.