Rewrite DerivedSeriesOfGroup to check for abelian derived subgroups #585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DerivedSeriesOfGroup is rewritten to check for the derived subgroup being
abelian. In some cases this may terminate for fp-groups for which the old
method did not, in the expense of an extra IsAbelian check for each term.
Insted of while do, repeat until is used to decrease code repetition.
Test file is added.
This is supposed to fix #584, where some discussion is already started.
This attribute is one of the most basic in GAP, so please, everybody, (try to) tear it apart as long as it is not perfect.