Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deck OAuth #2

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Fix Deck OAuth #2

merged 3 commits into from
Nov 30, 2021

Conversation

timebertt
Copy link
Member

Switch from App auth to robot PAT in deck (used for resolving teams for the rerun auth configs).
Currently, OAuth flow isn't implemented in combination with app auth: kubernetes/test-infra#23870

With this, deck OAuth flow is fixed, i.e. one can now use the personal PR dashboard (https://prow.gardener.cloud/pr) and the rerun button triggers new jobs (if you're part of the required team).

@timebertt timebertt requested a review from a team as a code owner November 30, 2021 10:43
@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@gardener-robot gardener-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2021
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2021
OWNERS superseeds the CODEOWNERS file
@gardener-robot gardener-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2021
@gardener-prow gardener-prow bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2021
@timebertt timebertt removed the request for review from a team November 30, 2021 10:49
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@gardener-prow
Copy link

gardener-prow bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke, timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit 3085b95 into master Nov 30, 2021
@gardener-prow gardener-prow bot deleted the deck-oauth branch November 30, 2021 11:43
@gardener-prow
Copy link

gardener-prow bot commented Nov 30, 2021

@timebertt: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key postsubmits.yaml using file ``
  • key ci-infra-postsubmits.yaml using file config/jobs/ci-infra/ci-infra-postsubmits.yaml
  • key presubmits.yaml using file ``
  • key ci-infra-presubmits.yaml using file config/jobs/ci-infra/ci-infra-presubmits.yaml

In response to this:

Switch from App auth to robot PAT in deck (used for resolving teams for the rerun auth configs).
Currently, OAuth flow isn't implemented in combination with app auth: kubernetes/test-infra#23870

With this, deck OAuth flow is fixed, i.e. one can now use the personal PR dashboard (https://prow.gardener.cloud/pr) and the rerun button triggers new jobs (if you're part of the required team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gardener-ci-robot pushed a commit to gardener-ci-robot/ci-infra that referenced this pull request Nov 3, 2022
…b-forker-test

Forked prow jobs for repo: oliver-goetz/ci-infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants