Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FQDN for ghproxy endpoint in prow jobs #778

Merged

Conversation

oliver-goetz
Copy link
Member

/kind bug

What this PR does / why we need it:
Use FQDN for ghproxy endpoint in prow jobs because prow job pods run in test-pods namespace.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@gardener-prow gardener-prow bot added the kind/bug Bug label Jul 10, 2023
@gardener-prow gardener-prow bot requested review from rfranzke and timuthy July 10, 2023 15:47
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jul 11, 2023

LGTM label has been added.

Git tree hash: 6a14ceb7af0bccbb77ef387ed98e7b7712a5e249

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@gardener-prow gardener-prow bot merged commit 6465305 into gardener:master Jul 11, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jul 11, 2023

@oliver-goetz: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key ci-infra-periodics.yaml using file config/jobs/ci-infra/ci-infra-periodics.yaml

In response to this:

/kind bug

What this PR does / why we need it:
Use FQDN for ghproxy endpoint in prow jobs because prow job pods run in test-pods namespace.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliver-goetz oliver-goetz deleted the enh/change-ghproxy-endpoints branch July 11, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants