-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote experimentalUseWatchCacheForListShoots
to stable
#1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 18, 2024
gardener-robot
added
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Apr 18, 2024
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 18, 2024
@holgerkoser, @grolu You have pull request review open invite, please check |
holgerkoser
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
labels
Apr 24, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 24, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 24, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 24, 2024
gardener-robot
added
needs/second-opinion
Needs second review by someone else
and removed
reviewed/lgtm
Has approval for merging
labels
Apr 24, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Apr 24, 2024
petersutter
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 24, 2024
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Apr 24, 2024
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Apr 24, 2024
holgerkoser
added a commit
that referenced
this pull request
Apr 29, 2024
* master: Update vitest monorepo to v1.5.2 (#1844) Promote `experimentalUseWatchCacheForListShoots` to stable (#1822) Update dependency supertest to v7 (#1843) Update vitest monorepo to v1.5.1 (#1840) Add hack/cherry-pick-pull.sh (#1831) Make OIDC clientSecret optional (#1835) Create `Lease` during runtime, if not found (#1823) Update actions/checkout action to v4.1.4 (#1841) Update dependency vuetify to v3.5.17 (#1839) Update actions/checkout action to v4.1.3 (#1834) Update dependency vue to v3.4.25 (#1837) Update renovate.json5 migrate to new @xterm scoped packages (#1832)
petersutter
added
the
area/ipcei
IPCEI (Important Project of Common European Interest)
label
May 6, 2024
1 task
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ipcei
IPCEI (Important Project of Common European Interest)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have now used
Values.global.dashboard.experimentalUseWatchCacheForListShoots=always
in our production environment since it was first introduced with #1637 without issues.With this PR we remove the
experimentalUseWatchCacheForListShoots
, which is equivalent of the settingValues.global.dashboard.experimentalUseWatchCacheForListShoots=always
.Which issue(s) this PR fixes:
Fixes #1788
Special notes for your reviewer:
Release note:
Promoting `experimentalUseWatchCacheForListShoots` to Stable - The `experimentalUseWatchCacheForListShoots` feature flag in the gardener-dashboard Helm chart, which was introduced with #1637, has now been promoted to stable and removed. Previously, this feature was gated behind the `Values.global.dashboard.experimentalUseWatchCacheForListShoots` Helm chart value. With this release, the feature is now enabled by default, which is equivalent to setting `Values.global.dashboard.experimentalUseWatchCacheForListShoots: always`