Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote experimentalUseWatchCacheForListShoots to stable #1822

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
We have now used Values.global.dashboard.experimentalUseWatchCacheForListShoots=always in our production environment since it was first introduced with #1637 without issues.

With this PR we remove the experimentalUseWatchCacheForListShoots, which is equivalent of the setting Values.global.dashboard.experimentalUseWatchCacheForListShoots=always.

Which issue(s) this PR fixes:
Fixes #1788

Special notes for your reviewer:

Release note:

Promoting `experimentalUseWatchCacheForListShoots` to Stable
- The `experimentalUseWatchCacheForListShoots` feature flag in the gardener-dashboard Helm chart, which was introduced with #1637, has now been promoted to stable and removed. Previously, this feature was gated behind the `Values.global.dashboard.experimentalUseWatchCacheForListShoots` Helm chart value. With this release, the feature is now enabled by default, which is equivalent to setting `Values.global.dashboard.experimentalUseWatchCacheForListShoots: always`

@gardener-robot gardener-robot added the needs/review Needs review label Apr 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 18, 2024
@gardener-robot
Copy link

@holgerkoser, @grolu You have pull request review open invite, please check

Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Apr 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 24, 2024
@petersutter petersutter added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 24, 2024
@petersutter petersutter merged commit 7a41a01 into master Apr 24, 2024
9 checks passed
@petersutter petersutter deleted the enh/stable-watch-cache-for-shoot-list branch April 24, 2024 16:46
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 24, 2024
holgerkoser added a commit that referenced this pull request Apr 29, 2024
* master:
  Update vitest monorepo to v1.5.2 (#1844)
  Promote `experimentalUseWatchCacheForListShoots` to stable (#1822)
  Update dependency supertest to v7 (#1843)
  Update vitest monorepo to v1.5.1 (#1840)
  Add hack/cherry-pick-pull.sh (#1831)
  Make OIDC clientSecret optional (#1835)
  Create `Lease` during runtime, if not found (#1823)
  Update actions/checkout action to v4.1.4 (#1841)
  Update dependency vuetify to v3.5.17 (#1839)
  Update actions/checkout action to v4.1.3 (#1834)
  Update dependency vue to v3.4.25 (#1837)
  Update renovate.json5
  migrate to new @xterm scoped packages (#1832)
@petersutter petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote experimentalUseWatchCacheForListShoots to stable
6 participants