Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional as a boolean field and not a pointer in prober api #71

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Optional as a boolean field and not a pointer in prober api #71

merged 2 commits into from
Nov 23, 2022

Conversation

rishabh-11
Copy link
Collaborator

What this PR does / why we need it:
This PR changes the prober API to make optional a boolean field and not a pointer.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-robot gardener-robot added needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
unmarshall
unmarshall approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@unmarshall unmarshall merged commit 83f3233 into gardener:master Nov 23, 2022
@rishabh-11 rishabh-11 deleted the api-change branch December 8, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh-11 @unmarshall @gardener-robot-ci-2 @gardener-robot