Updated the MultiNode proposal: To take out-of-sync snapshots delegate the incoming http request to backup-leader. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
ishan16696
added
status/on-hold
timuthy
reviewed
Oct 29, 2021
There was a problem hiding this comment.
I'd suggest to first discuss details in gardener/etcd-backup-restore#354 before we move on and merge this PR.
timuthy
reviewed
Nov 2, 2021
ishan16696
force-pushed
the
Updated-multi-node-doc
branch
from
187be1d
to
409ecf2
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
…egate the incoming http request to leading-sidecar.
ishan16696
force-pushed
the
Updated-multi-node-doc
branch
from
409ecf2
to
6161bec
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updated the MultiNode proposal:
To take out-of-sync full/delta snapshots delegate the incoming http request to
backup-restore leaderand Let thebackup-restore leadertake/upload the out-of-sync snapshot(full as well as incremental)I had already created a issue regarding this: gardener/etcd-backup-restore#354
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: