Several improvements for compaction feature #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
timuthy
changed the title
timuthy
force-pushed
the
enhancements.etcd-druid-v070
branch
from
76f9173
to
a3ea979
Compare
gardener-robot
added
size/l
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
timuthy
force-pushed
the
enhancements.etcd-druid-v070
branch
from
a3ea979
to
bb41a11
Compare
gardener-robot
added
size/xl
gardener-robot-ci-2
added
the
reviewed/ok-to-test
The chosen names are a closer match to names that are already used in the Gardener space.
We don't want to set initial values for full/delta Lease objects because the etcd-backup-restore sidecar is suppossed to set the corresponding values. It's the only component which determins the full- and delta-snapshot revisions. If we set initial values (`0`) then the controller might create unexpected compaction jobs.
timuthy
force-pushed
the
enhancements.etcd-druid-v070
branch
from
bb41a11
to
2da78cb
Compare
gardener-robot
added
size/l
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
timuthy
force-pushed
the
enhancements.etcd-druid-v070
branch
from
2da78cb
to
4141b63
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
abdasgupta
approved these changes
Nov 15, 2021
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
This PR adds some additions after merging #235 for release
v0.7.0. Please have a look at the individual commit messages for more information.Special notes for your reviewer:
This PR will stay in draft mode until #235 is merged.Release note:
A new flag `--enable-backup-compation` has been introduced which globally enables automatic compaction of backups.