Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serviceName and podManagementPolicy field updates #408

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fix serviceName and podManagementPolicy field updates #408

merged 1 commit into from
Aug 19, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 18, 2022

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
This PR fixes an issue that made Etcd-Druid to update sts.spec.serviceName and sts.spec.podManagementPolicy for older etcd resources. Those are immutable fields that should only be updated when a scale-up is performed and thus a disruption is excepted (by first deleting the statefulset and re-creating it afterwards).

Which issue(s) this PR fixes:
Fixes #404

Release note:

An issue has been fixed that caused Etcd-Druid to update immutable fields `sts.spec.serviceName` and `sts.spec.podManagementPolicy` for older `etcd` resources that had different values configured. These updates must only happen when a etcd cluster is scaled up for the first time (`1 -> x`) because (a) then these values are mandatory and (b) a disruption is accepted.

@timuthy timuthy requested a review from a team as a code owner August 18, 2022 09:11
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review Needs review labels Aug 18, 2022
@timuthy
Copy link
Member Author

timuthy commented Aug 18, 2022

/invite @aaronfern

@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Aug 18, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 18, 2022
aaronfern
aaronfern approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 19, 2022
@timuthy timuthy merged commit 9588c6c into gardener:master Aug 19, 2022
@timuthy timuthy deleted the fix.sts-immutable-fields branch August 19, 2022 06:34
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 19, 2022
@shreyas-s-rao shreyas-s-rao mentioned this pull request Dec 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Statefulset updation fails as druid attempts to update forbidden fields
4 participants
@timuthy @aaronfern @gardener-robot-ci-2 @gardener-robot