Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e tests for multi-node etcd #418

Merged
merged 7 commits into from
Sep 23, 2022
Merged

Add e2e tests for multi-node etcd #418

merged 7 commits into from
Sep 23, 2022

Conversation

seshachalam-yv
Copy link
Contributor

@seshachalam-yv seshachalam-yv commented Aug 28, 2022 •
edited

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
This PR adds e2e tests for multi-node etcd for below cases,

Etcd cluster operations:

  • Creation of 3-member etcd cluster
  • Hibernation
    • Scale down from 3->0
    • Scale up from 0->3
  • Zero downtime rolling updates
  • Zero downtime maintenance operations - Defragmentation
  • Deletion of 3-member etcd cluster

Scaling

  • Scale up of a healthy cluster (from 1->3)
  • Scale down of a healthy cluster (from 3->1) - (but commented, because this case not yet supported.)

Release note:

NONE

@seshachalam-yv seshachalam-yv requested a review from a team as a code owner August 28, 2022 12:30
@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension labels Aug 28, 2022
@gardener-robot
Copy link

@seshachalam-yv Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 28, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 28, 2022
@seshachalam-yv seshachalam-yv mentioned this pull request Aug 28, 2022
Closed
9 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 28, 2022
@timuthy timuthy mentioned this pull request Aug 29, 2022
Closed
@timuthy
Copy link
Member

timuthy commented Aug 29, 2022

/assign

timuthy
timuthy suggested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely done with the review and plan to do some test runs. Nevertheless, please see already some feedback. In general it looks good, thanks a lot for the tests 🙂

test/e2e/etcd_backup_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_backup_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_backup_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 30, 2022
unmarshall
unmarshall reviewed Aug 30, 2022
View reviewed changes
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Show resolved Hide resolved
unmarshall
unmarshall reviewed Aug 31, 2022
View reviewed changes
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
@seshachalam-yv seshachalam-yv requested review from timuthy and unmarshall and removed request for timuthy September 1, 2022 14:02
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
ishan16696
ishan16696 requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seshachalam-yv ,
Thanks for PR. Can you also please rebase this PR on latest master ?

test/e2e/utils.go Show resolved Hide resolved
test/e2e/utils.go Show resolved Hide resolved
test/e2e/utils.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 8, 2022
ishan16696
ishan16696 requested changes Sep 9, 2022
View reviewed changes
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2022
unmarshall
unmarshall reviewed Sep 12, 2022
View reviewed changes
test/e2e/etcd_backup_test.go Show resolved Hide resolved
test/e2e/etcd_backup_test.go Show resolved Hide resolved
test/e2e/etcd_backup_test.go Show resolved Hide resolved
test/e2e/etcd_backup_test.go Show resolved Hide resolved
test/e2e/etcd_backup_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2022
@ishan16696
Copy link
Member

Hi @seshachalam-yv ,
Can you re-push a commit to re-run the pipeline checks as I'm unable to retrigger the pipeline tests as one of the checks is pending.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2022
unmarshall
unmarshall approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm with minor comments

test/e2e/etcd_backup_test.go Outdated Show resolved Hide resolved
test/e2e/etcd_multi_node_test.go Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 23, 2022
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Sep 23, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2022
@ishan16696 ishan16696 merged commit 6f771ab into gardener:master Sep 23, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 23, 2022
@seshachalam-yv seshachalam-yv deleted the e2e-multi-node-etcd branch September 23, 2022 06:37
@aaronfern aaronfern mentioned this pull request Sep 29, 2022
Merged
@abdasgupta abdasgupta mentioned this pull request Nov 8, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@unmarshall unmarshall unmarshall approved these changes

@timuthy timuthy timuthy approved these changes

Assignees

@timuthy timuthy

Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@seshachalam-yv @gardener-robot @timuthy @ishan16696 @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3