Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e tests that failed due to changes made to condition handling #442

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix e2e tests that failed due to changes made to condition handling #442

merged 1 commit into from
Oct 4, 2022

Conversation

aaronfern
Copy link
Contributor

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
With the inclusion of #415, some changes were made to the way etcd-druid maintains conditions in the etcd status. This has affected e2e tests introduced in #418 as these tests expect certain conditions that are now not the case with #415

This PR updates the tests so that they expect the correct conditions in line with the way etcd-druid now maintains the conditions.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
@seshachalam-yv

Release note:

@aaronfern aaronfern requested a review from a team as a code owner September 29, 2022 09:18
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 29, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2022
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 29, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2022
seshachalam-yv
seshachalam-yv approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@seshachalam-yv Command /lgtm is not available to you but only to a Maintainer, Member.

@ishan16696 ishan16696 merged commit 59bfd27 into gardener:master Oct 4, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aaronfern @gardener-robot @ishan16696 @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-3