-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Druid e2e tests for multi node etcd #405
Add Druid e2e tests for multi node etcd #405
Conversation
Co-authored-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
Co-authored-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@seshachalam-yv Thank you for your contribution. |
Thank you @seshachalam-yv for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | RSA Private Key | 967218c | test/e2e/resources/certs/ca.key | View secret |
- | RSA Private Key | 967218c | test/e2e/resources/certs/client.key | View secret |
- | RSA Private Key | 967218c | test/e2e/resources/certs/server.key | View secret |
- | RSA Private Key | b95b50e | test/e2e/resources/certs/client.key | View secret |
- | RSA Private Key | b95b50e | test/e2e/resources/certs/server.key | View secret |
- | Generic Private Key | b95b50e | test/e2e/resources/tls/client.key | View secret |
- | Generic Private Key | b95b50e | test/e2e/resources/tls/server.key | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Thanks for the PR and effort @seshachalam-yv. Since #296 has been merged, can you please rebase this PR and adapt to the latest structural changes introduced in |
/needs rebase |
Closed this PR, opened another PR to track this #418 |
How to categorize this PR?
/area testing
/kind enhancement
What this PR does / why we need it:
This PR adds e2e tests for multi-node etcd
Etcd cluster operations:
need to investigate why etcd cluster is not healthy while rolling update
)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR made changes on top of #296.
Introduced multi-node e2e tests and helper functions in following files
Depends on the following issues/PRs:
#296
Release note: