Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Druid e2e tests for multi node etcd #405

Closed

Conversation

seshachalam-yv
Copy link
Contributor

@seshachalam-yv seshachalam-yv commented Aug 11, 2022

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
This PR adds e2e tests for multi-node etcd

Etcd cluster operations:

  • Creation of 3-member etcd cluster
  • Hibernation
    • Scale down from 3->0
    • Scale up from 0->3
  • Quorum is lost
  • Single node is restored
  • Zero downtime rolling updates ---> skipped (need to investigate why etcd cluster is not healthy while rolling update)
  • Zero downtime maintenance operations - Defragmentation
  • Deletion of 3-member etcd cluster

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This PR made changes on top of #296.
Introduced multi-node e2e tests and helper functions in following files

Depends on the following issues/PRs:
#296

Release note:


@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension labels Aug 11, 2022
@gardener-robot
Copy link

@seshachalam-yv Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 11, 2022
@gardener-robot-ci-3
Copy link
Contributor

Thank you @seshachalam-yv for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gitguardian
Copy link

gitguardian bot commented Aug 11, 2022

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- RSA Private Key 967218c test/e2e/resources/certs/ca.key View secret
- RSA Private Key 967218c test/e2e/resources/certs/client.key View secret
- RSA Private Key 967218c test/e2e/resources/certs/server.key View secret
- RSA Private Key b95b50e test/e2e/resources/certs/client.key View secret
- RSA Private Key b95b50e test/e2e/resources/certs/server.key View secret
- Generic Private Key b95b50e test/e2e/resources/tls/client.key View secret
- Generic Private Key b95b50e test/e2e/resources/tls/server.key View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@seshachalam-yv seshachalam-yv changed the title E2e multi node etcd Add Druid e2e tests for multi node etcd Aug 11, 2022
@seshachalam-yv seshachalam-yv marked this pull request as ready for review August 11, 2022 08:04
@seshachalam-yv seshachalam-yv requested a review from a team as a code owner August 11, 2022 08:04
@ishan16696 ishan16696 added reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2022
@timuthy
Copy link
Member

timuthy commented Aug 18, 2022

Thanks for the PR and effort @seshachalam-yv. Since #296 has been merged, can you please rebase this PR and adapt to the latest structural changes introduced in test/e2e/etcd_backup_test.go?

@timuthy
Copy link
Member

timuthy commented Aug 18, 2022

/needs rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Aug 18, 2022
@seshachalam-yv seshachalam-yv deleted the e2e-multi-node-etcd branch August 28, 2022 12:19
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 28, 2022
@seshachalam-yv
Copy link
Contributor Author

Closed this PR, opened another PR to track this #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants