Added e2e tests for single member restoration #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/testing
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
size/m
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
ishan16696
reviewed
Oct 27, 2022
seshachalam-yv
requested changes
Nov 2, 2022
test/e2e/etcd_multi_node_test.go
Outdated
| @@ -138,6 +152,56 @@ var _ = Describe("Etcd", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| func deleteMemberDir(ctx context.Context, cl client.Client, logger logr.Logger, etcd *v1alpha1.Etcd, podName string) { | |||
| Expect(deleteDir(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member")).To(Succeed()) | |||
There was a problem hiding this comment.
Suggested change
| Expect(deleteDir(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member")).To(Succeed()) | |
| ExpectWithOffset(1, deleteDir(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member")).To(Succeed()) |
test/e2e/etcd_multi_node_test.go
Outdated
|
|
||
| func checkUnreadySts(ctx context.Context, cl client.Client, logger logr.Logger, etcd *v1alpha1.Etcd) { | ||
| logger.Info("waiting for sts to become unready", "statefulSetName", "etcd-aws") | ||
| Eventually(func() error { |
There was a problem hiding this comment.
Suggested change
| Eventually(func() error { | |
| EventuallyWithOffset(2, func() error { |
test/e2e/etcd_multi_node_test.go
Outdated
| @@ -105,6 +106,19 @@ var _ = Describe("Etcd", func() { | |||
| // K8s job zeroDownTimeValidator will fail, if there is any downtime in Etcd cluster health. | |||
| checkEtcdZeroDownTimeValidatorJob(ctx, cl, client.ObjectKeyFromObject(job), objLogger) | |||
|
|
|||
| By("Single member restoration") | |||
| objLogger.Info("Delete one member pod") | |||
| deletePodAndCheckSts(ctx, cl, logger, etcd, "etcd-aws-2") | |||
There was a problem hiding this comment.
Pls pass objLogger instead of logger , because it already contains etcd obj info.
test/e2e/etcd_multi_node_test.go
Outdated
| By("Single member restoration") | ||
| objLogger.Info("Delete one member pod") | ||
| deletePodAndCheckSts(ctx, cl, logger, etcd, "etcd-aws-2") | ||
| checkEtcdReady(ctx, cl, logger, etcd, multiNodeEtcdTimeout) |
There was a problem hiding this comment.
Pls pass objLogger instead of logger , because it already contains etcd obj info.
test/e2e/etcd_multi_node_test.go
Outdated
|
|
||
| objLogger.Info("Delete member dir of one member pod") | ||
| deleteMemberDir(ctx, cl, logger, etcd, "etcd-aws-2") | ||
| checkEtcdReady(ctx, cl, logger, etcd, multiNodeEtcdTimeout) |
There was a problem hiding this comment.
Pls pass objLogger instead of logger , because it already contains etcd obj info.
test/e2e/etcd_multi_node_test.go
Outdated
| } | ||
|
|
||
| func corruptMemberDBFile(ctx context.Context, cl client.Client, logger logr.Logger, etcd *v1alpha1.Etcd, podName string) { | ||
| Expect(corruptDBFile(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member/snap/db")).To(Succeed()) |
There was a problem hiding this comment.
Suggested change
| Expect(corruptDBFile(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member/snap/db")).To(Succeed()) | |
| ExpectWithOffset(1, corruptDBFile(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member/snap/db")).To(Succeed()) |
test/e2e/etcd_multi_node_test.go
Outdated
| func corruptMemberDBFile(ctx context.Context, cl client.Client, logger logr.Logger, etcd *v1alpha1.Etcd, podName string) { | ||
| Expect(corruptDBFile(kubeconfigPath, namespace, podName, "backup-restore", "/var/etcd/data/new.etcd/member/snap/db")).To(Succeed()) | ||
| checkUnreadySts(ctx, cl, logger, etcd) | ||
| checkReadySts(ctx, cl, logger, etcd) |
There was a problem hiding this comment.
Here also
Suggested change
| checkReadySts(ctx, cl, logger, etcd) | |
| checkEtcdReady(ctx, cl, logger, etcd, multiNodeEtcdTimeout) |
test/e2e/etcd_multi_node_test.go
Outdated
| } | ||
|
|
||
| func checkUnreadySts(ctx context.Context, cl client.Client, logger logr.Logger, etcd *v1alpha1.Etcd) { | ||
| logger.Info("waiting for sts to become unready", "statefulSetName", "etcd-aws") |
There was a problem hiding this comment.
Pls ignore statefulSetName info and pass objLogger
test/e2e/etcd_multi_node_test.go
Outdated
| } | ||
| return nil | ||
| }, multiNodeEtcdTimeout, pollingInterval).Should(BeNil()) | ||
| logger.Info("sts is unready", "statefulSetName", "etcd-aws") |
There was a problem hiding this comment.
Pls ignore sts name here also
test/e2e/etcd_multi_node_test.go
Outdated
|
|
||
| func checkReadySts(ctx context.Context, cl client.Client, logger logr.Logger, etcd *v1alpha1.Etcd) { | ||
| logger.Info("waiting for sts to become ready again", "statefulSetName", "etcd-aws") | ||
| Eventually(func() error { |
There was a problem hiding this comment.
Suggested change
| Eventually(func() error { | |
| EventuallyWithOffset(2, func() error { |
ishan16696
approved these changes
Nov 4, 2022
seshachalam-yv
approved these changes
Nov 4, 2022
gardener-robot
added
the
status/closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind enhancement
What this PR does / why we need it:
This PR Adds a few e2e tests for the multi node scenario to test single node restoration.
It adds the following tests:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: