-
Notifications
You must be signed in to change notification settings - Fork 69
/
Copy pathreconciler.go
614 lines (563 loc) · 19.4 KB
/
reconciler.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
// SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Gardener contributors
//
// SPDX-License-Identifier: Apache-2.0
package source
import (
"fmt"
"reflect"
"strings"
"time"
"github.com/gardener/controller-manager-library/pkg/controllermanager/controller"
"github.com/gardener/controller-manager-library/pkg/controllermanager/controller/reconcile"
"github.com/gardener/controller-manager-library/pkg/controllermanager/controller/reconcile/reconcilers"
"github.com/gardener/controller-manager-library/pkg/logger"
"github.com/gardener/controller-manager-library/pkg/resources"
"github.com/gardener/controller-manager-library/pkg/resources/access"
"github.com/gardener/controller-manager-library/pkg/utils"
api "github.com/gardener/external-dns-management/pkg/apis/dns/v1alpha1"
"github.com/gardener/external-dns-management/pkg/controller/annotation/annotations"
"github.com/gardener/external-dns-management/pkg/dns"
dnsutils "github.com/gardener/external-dns-management/pkg/dns/utils"
core "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
)
// NewSlaveAccessSpec creates a new SlaveAccessSpec.
func NewSlaveAccessSpec(c controller.Interface, sourceType DNSSourceType) reconcilers.SlaveAccessSpec {
spec := reconcilers.NewSlaveAccessSpec(c, sourceType.Name(), SlaveResources, MasterResourcesType(sourceType.GroupKind()))
spec.Namespace, _ = c.GetStringOption(OPT_NAMESPACE)
return spec
}
// SourceReconciler returns a ReconcilerType method.
func SourceReconciler(sourceType DNSSourceType, rtype controller.ReconcilerType) controller.ReconcilerType {
return func(c controller.Interface) (reconcile.Interface, error) {
source, err := sourceType.Create(c)
if err != nil {
return nil, err
}
opt, err := c.GetStringOption(OPT_TARGET_REALMS)
if err != nil {
opt = ""
}
realmtype := access.NewRealmType(dns.REALM_ANNOTATION)
realms := realmtype.NewRealms(opt)
c.Infof("target realm(s): %v", realms)
classes := controller.NewClassesByOption(c, OPT_CLASS, dns.CLASS_ANNOTATION, dns.DEFAULT_CLASS)
c.SetFinalizerHandler(controller.NewFinalizerForClasses(c, c.GetDefinition().FinalizerName(), classes))
targetclasses := controller.NewTargetClassesByOption(c, OPT_TARGET_CLASS, dns.CLASS_ANNOTATION, classes)
slaves, err := reconcilers.NewSlaveAccessBySpec(c, NewSlaveAccessSpec(c, sourceType))
if err != nil {
return nil, err
}
ownerState, err := getOrCreateSharedOwnerState(c, false)
if err != nil {
return nil, err
}
reconciler := &sourceReconciler{
SlaveAccess: slaves,
classes: classes,
targetclasses: targetclasses,
targetrealms: realms,
state: c.GetOrCreateSharedValue(KEY_STATE,
func() interface{} {
return NewState(ownerState)
}).(*state),
annotations: annotations.GetOrCreateWatches(c),
}
reconciler.annotations.RegisterHandler(c, sourceType.GroupKind(), reconciler)
reconciler.state.source = source
reconciler.namespace, _ = c.GetStringOption(OPT_NAMESPACE)
reconciler.nameprefix, _ = c.GetStringOption(OPT_NAMEPREFIX)
reconciler.creatorLabelName, _ = c.GetStringOption(OPT_TARGET_CREATOR_LABEL_NAME)
reconciler.creatorLabelValue, _ = c.GetStringOption(OPT_TARGET_CREATOR_LABEL_VALUE)
reconciler.setIgnoreOwners, _ = c.GetBoolOption(OPT_TARGET_SET_IGNORE_OWNERS)
excluded, _ := c.GetStringArrayOption(OPT_EXCLUDE)
reconciler.excluded = utils.NewStringSetByArray(excluded)
reconciler.Infof("found excluded domains: %v", reconciler.excluded)
if c.GetMainCluster() == c.GetCluster(TARGET_CLUSTER) {
reconciler.namespace = ""
reconciler.nameprefix = ""
}
nested, err := reconcilers.NewNestedReconciler(rtype, reconciler)
if err != nil {
return nil, err
}
reconciler.NestedReconciler = nested
return reconciler, nil
}
}
type sourceReconciler struct {
*reconcilers.NestedReconciler
*reconcilers.SlaveAccess
excluded utils.StringSet
classes *controller.Classes
targetclasses *controller.Classes
targetrealms *access.Realms
namespace string
nameprefix string
creatorLabelName string
creatorLabelValue string
setIgnoreOwners bool
state *state
annotations *annotations.State
}
func (this *sourceReconciler) ObjectUpdated(key resources.ClusterObjectKey) {
this.Infof("requeue %s because of change in annotation resource", key)
_ = this.EnqueueKey(key)
}
func (this *sourceReconciler) Setup() error {
err := this.state.ownerState.Setup(this)
if err != nil {
return err
}
this.SlaveAccess.Setup()
if err := this.state.source.Setup(); err != nil {
return err
}
return this.NestedReconciler.Setup()
}
func (this *sourceReconciler) lookupSlavesResponsible(logger logger.LogContext, key resources.ClusterObjectKey) []resources.Object {
var slavesResponsible []resources.Object
for _, obj := range this.LookupSlaves(key) {
if !this.targetclasses.IsResponsibleFor(logger, obj) {
continue
}
slavesResponsible = append(slavesResponsible, obj)
}
return slavesResponsible
}
func (this *sourceReconciler) Reconcile(logger logger.LogContext, obj resources.Object) reconcile.Status {
slaves := this.lookupSlavesResponsible(logger, obj.ClusterKey())
names := dns.DNSNameSet{}
for _, s := range slaves {
names.Add(dnsutils.DNSEntry(s).DNSSetName())
}
found := &DNSCurrentState{Names: map[dns.DNSSetName]*DNSState{}, Targets: utils.StringSet{}}
for n := range names {
s := this.AssertSingleSlave(logger, obj.ClusterKey(), slaves, dnsutils.DNSSetNameMatcher(n))
e := dnsutils.DNSEntry(s).DNSEntry()
found.Names[n] = &DNSState{DNSEntryStatus: e.Status, CreationTimestamp: e.CreationTimestamp}
found.Targets.AddAll(e.Spec.Targets)
}
info, responsible, err := this.getDNSInfo(logger, obj, this.state.source, found)
if err != nil {
obj.Event(core.EventTypeWarning, "reconcile", err.Error())
}
this.state.SetDep(obj.ClusterKey(), this.usedRef(obj, info))
if !responsible {
if len(slaves) > 0 {
logger.Infof("not responsible anymore, but still found slaves (cleanup required): %v", resources.ObjectArrayToString(slaves...))
info = &DNSInfo{}
}
}
feedback := this.state.CreateFeedbackForObject(obj)
if info == nil {
if responsible {
logger.Debugf("no dns info found")
err2 := this.annotations.SetActive(obj.ClusterKey(), false)
if err2 != nil {
err = err2
}
}
if err != nil {
return reconcile.Failed(logger, err)
}
return reconcile.Succeeded(logger).Stop()
} else {
// if not responsible now it was responsible, therefore cleanup the active state
err = this.annotations.SetActive(obj.ClusterKey(), responsible)
if err != nil {
return reconcile.Delay(logger, err)
}
}
missing := dns.DNSNameSet{}
obsolete := []resources.Object{}
obsolete_dns := dns.DNSNameSet{}
current := []resources.Object{}
if len(info.Names) > 0 && RequireFinalizer(obj, this.SlaveResoures()[0].GetCluster()) {
err := this.SetFinalizer(obj)
if err != nil {
return reconcile.Delay(logger, fmt.Errorf("cannot set finalizer: %s", err))
}
} else {
err := this.RemoveFinalizer(obj)
if err != nil {
return reconcile.Delay(logger, fmt.Errorf("cannot remove finalizer: %s", err))
}
}
logger.Debugf("found names: %s", info.Names)
outer:
for name := range info.Names {
for _, s := range slaves {
slaveName := dnsutils.DNSEntry(s).DNSSetName()
if slaveName == name {
continue outer
}
}
missing.Add(name)
}
for _, s := range slaves {
slaveName := dnsutils.DNSEntry(s).DNSSetName()
if !info.Names.Contains(slaveName) {
obsolete = append(obsolete, s)
obsolete_dns.Add(slaveName)
} else {
current = append(current, s)
}
}
var notifiedErrors []string
modified := map[dns.DNSSetName]bool{}
if len(missing) > 0 {
if len(info.Targets) > 0 || len(info.Text) > 0 || info.OrigRef != nil {
logger.Infof("found missing dns entries: %s", missing)
for name := range missing {
err := this.createEntryFor(logger, obj, name, info, feedback)
if err != nil {
notifiedErrors = append(notifiedErrors, fmt.Sprintf("cannot create dns entry object for %s: %s ", name, err))
}
}
} else {
logger.Infof("no targets found -> omit creation of missing dns entries: %s", missing)
}
}
if len(obsolete_dns) > 0 {
logger.Infof("found obsolete dns entries: %s", obsolete_dns)
for _, o := range obsolete {
name := dnsutils.DNSEntry(o).DNSSetName()
err := this.deleteEntry(logger, o, name, feedback)
if err != nil {
notifiedErrors = append(notifiedErrors, fmt.Sprintf("cannot remove dns entry object %q(%s): %s", o.ClusterKey(), name, err))
}
}
}
if len(current) > 0 {
for _, o := range current {
name := dnsutils.DNSEntry(o).DNSSetName()
mod, err := this.updateEntryFor(logger, obj, info, o)
modified[name] = mod
if err != nil {
notifiedErrors = append(notifiedErrors, fmt.Sprintf("cannot update dns entry object %q(%s): %s", o.ClusterKey(), name, err))
}
}
}
for key := range this.state.GetUsed(obj.ClusterKey()) {
_ = this.EnqueueKey(key)
}
if len(notifiedErrors) > 0 {
msg := strings.Join(notifiedErrors, ", ")
if feedback != nil {
feedback.Failed(logger, "", fmt.Errorf("%s", msg), nil)
}
return reconcile.Delay(logger, fmt.Errorf("reconcile failed: %s", msg))
}
if feedback != nil {
threshold := time.Now().Add(-2 * time.Minute)
for n := range info.Names {
s := found.Names[n]
if s != nil && !modified[n] {
switch s.State {
case api.STATE_ERROR:
case api.STATE_INVALID:
case api.STATE_PENDING:
case api.STATE_READY:
default:
if s.CreationTimestamp.Time.Before(threshold) {
feedback.Pending(logger, n.String(), "no dns controller running?", s)
}
}
}
}
feedback.Succeeded(logger)
}
status := this.NestedReconciler.Reconcile(logger, obj)
if status.IsSucceeded() {
if len(info.Names) == 0 {
return status.Stop()
}
}
return status
}
// Deleted is used as fallback, if the source object in another cluster is
//
// deleted unexpectedly (by removing the finalizer).
// It checks whether a slave is still available and deletes it.
func (this *sourceReconciler) Deleted(logger logger.LogContext, key resources.ClusterObjectKey) reconcile.Status {
// For unclear reasons, k8s client lister spuriously can "forget" an object for some seconds (seen with K8S 1.17.7).
// As a mitigation, the cache and the kube-apiserver are checked again here.
if _, err := this.GetCachedObject(key); err == nil {
logger.Infof("deleted call for source %s delayed, as still in cache", key)
return reconcile.Recheck(logger, err, 60*time.Second)
}
if _, err := this.GetObject(key); err == nil {
logger.Infof("deleted call for source %s delayed, as still active", key)
return reconcile.Recheck(logger, err, 60*time.Second)
}
logger.Infof("%s finally deleted", key)
failed := false
for _, s := range this.Slaves().GetByOwnerKey(key) {
err := s.Delete()
if err != nil && !errors.IsNotFound(err) {
logger.Warnf("cannot delete entry object %s for %s: %s", s.ObjectName(), dnsutils.DNSEntry(s).GetDNSName(), err)
failed = true
} else {
logger.Infof("delete dns entry for vanished %s(%s)", s.ObjectName(), dnsutils.DNSEntry(s).GetDNSName())
}
}
if failed {
return reconcile.Delay(logger, nil)
}
this.state.DeleteFeedback(key)
this.state.source.Deleted(logger, key)
return this.NestedReconciler.Deleted(logger, key)
}
func (this *sourceReconciler) Delete(logger logger.LogContext, obj resources.Object) reconcile.Status {
if !this.classes.IsResponsibleFor(logger, obj) {
return reconcile.Succeeded(logger)
}
failed := false
logger.Infof("entry source is deleting -> delete all dns entries")
for _, s := range this.Slaves().GetByOwner(obj) {
logger.Infof("delete dns entry %s(%s)", s.ObjectName(), dnsutils.DNSEntry(s).GetDNSName())
err := s.Delete()
if err != nil && !errors.IsNotFound(err) {
logger.Warnf("cannot delete entry object %s for %s: %s", s.ObjectName(), dnsutils.DNSEntry(s).GetDNSName(), err)
failed = true
}
}
if failed {
return reconcile.Delay(logger, nil)
}
fb := this.state.GetFeedback(obj.ClusterKey())
if fb != nil {
fb.Deleted(logger, "", "deleting dns entries")
this.state.DeleteFeedback(obj.ClusterKey())
}
status := this.state.source.Delete(logger, obj)
if status.IsSucceeded() {
this.state.SetDep(obj.ClusterKey(), nil)
status = this.NestedReconciler.Delete(logger, obj)
if status.IsSucceeded() {
err := this.RemoveFinalizer(obj)
if err != nil {
return reconcile.Delay(logger, err)
}
}
}
return status
}
////////////////////////////////////////////////////////////////////////////////
func ref(r *api.EntryReference) string {
return fmt.Sprintf("%s/%s", r.Namespace, r.Name)
}
func (this *sourceReconciler) usedRef(obj resources.Object, info *DNSInfo) *resources.ClusterObjectKey {
if info != nil && info.OrigRef != nil && info.TargetRef == nil {
namespace := info.OrigRef.Namespace
if this.namespace == "" {
namespace = obj.GetNamespace()
}
ref := resources.NewClusterKey(obj.GetCluster().GetId(), entryGroupKind, namespace, info.OrigRef.Name)
return &ref
}
return nil
}
func (this *sourceReconciler) mapRef(obj resources.Object, info *DNSInfo) {
if info.OrigRef != nil && info.TargetRef == nil {
key := resources.NewClusterKey(obj.GetCluster().GetId(), entryGroupKind, info.OrigRef.Namespace, info.OrigRef.Name)
slaves := this.LookupSlaves(key)
info.TargetRef = &api.EntryReference{}
if len(slaves) == 1 {
// DNSEntry always has exactly one slave
info.TargetRef.Name = slaves[0].GetName()
info.TargetRef.Namespace = slaves[0].GetNamespace()
return
}
info.TargetRef.Name = info.OrigRef.Name + "-not-found"
if this.namespace == "" {
info.TargetRef.Namespace = obj.GetNamespace()
} else {
info.TargetRef.Namespace = this.namespace
}
}
}
func (this *sourceReconciler) createEntryFor(logger logger.LogContext, obj resources.Object, name dns.DNSSetName, info *DNSInfo, feedback DNSFeedback) error {
entry := &api.DNSEntry{}
entry.GenerateName = strings.ToLower(this.nameprefix + obj.GetName() + "-" + obj.GroupKind().Kind + "-")
if !this.targetclasses.IsDefault() {
resources.SetAnnotation(entry, CLASS_ANNOTATION, this.targetclasses.Main())
}
if !this.targetrealms.IsDefault() {
resources.SetAnnotation(entry, dns.REALM_ANNOTATION, this.targetrealms.AnnotationValue())
}
if this.setIgnoreOwners {
resources.SetAnnotation(entry, access.ANNOTATION_IGNORE_OWNERS, "true")
}
if this.creatorLabelName != "" && this.creatorLabelValue != "" {
resources.SetLabel(entry, this.creatorLabelName, this.creatorLabelValue)
}
if this.state.ownerState.ownerId != "" {
entry.Spec.OwnerId = &this.state.ownerState.ownerId
} else {
entry.Spec.OwnerId = info.OwnerId
}
entry.Spec.DNSName = name.DNSName
this.mapRef(obj, info)
if info.TargetRef != nil {
if info.OrigRef != nil {
logger.Infof("mapping entry reference %s to %s", ref(info.OrigRef), ref(info.TargetRef))
} else {
logger.Infof("using target reference %s", ref(info.TargetRef))
}
entry.Spec.Reference = info.TargetRef
} else {
entry.Spec.Targets = info.Targets.AsArray()
if info.Text != nil {
entry.Spec.Text = info.Text.AsArray()
}
}
if this.namespace == "" {
entry.Namespace = obj.GetNamespace()
} else {
entry.Namespace = this.namespace
}
entry.Spec.TTL = info.TTL
entry.Spec.RoutingPolicy = info.RoutingPolicy
if info.IPStack != "" {
annots := entry.GetAnnotations()
if annots == nil {
annots = map[string]string{}
}
annots[dns.AnnotationIPStack] = info.IPStack
entry.SetAnnotations(annots)
}
e, _ := this.SlaveResoures()[0].Wrap(entry)
err := this.Slaves().CreateSlave(obj, e)
if err != nil {
if feedback != nil {
feedback.Failed(logger, name.String(), err, nil)
}
return err
}
if feedback != nil {
feedback.Created(logger, name.String(), e.ObjectName())
} else {
logger.Infof("created dns entry object %s", e.ObjectName())
}
if feedback != nil {
feedback.Pending(logger, name.String(), "", nil)
}
return nil
}
func (this *sourceReconciler) updateEntryFor(logger logger.LogContext, obj resources.Object, info *DNSInfo, slave resources.Object) (bool, error) {
f := func(o resources.ObjectData) (bool, error) {
spec := &o.(*api.DNSEntry).Spec
mod := &utils.ModificationState{}
var changed bool
if !this.targetclasses.IsDefault() {
changed = resources.SetAnnotation(o, CLASS_ANNOTATION, this.targetclasses.Main())
} else {
changed = resources.RemoveAnnotation(o, CLASS_ANNOTATION)
}
mod.Modify(changed)
if !this.targetrealms.IsDefault() {
changed = resources.SetAnnotation(o, dns.REALM_ANNOTATION, this.targetrealms.AnnotationValue())
} else {
changed = resources.RemoveAnnotation(o, dns.REALM_ANNOTATION)
}
mod.Modify(changed)
if this.setIgnoreOwners {
changed = resources.SetAnnotation(o, access.ANNOTATION_IGNORE_OWNERS, "true")
} else {
changed = resources.RemoveAnnotation(o, access.ANNOTATION_IGNORE_OWNERS)
}
mod.Modify(changed)
if this.creatorLabelName != "" {
if this.creatorLabelValue != "" {
changed = resources.SetLabel(o, this.creatorLabelName, this.creatorLabelValue)
} else if this.creatorLabelName != "" {
changed = resources.RemoveLabel(o, this.creatorLabelName)
}
mod.Modify(changed)
}
var p *string
if this.state.ownerState.ownerId != "" {
p = &this.state.ownerState.ownerId
} else {
p = info.OwnerId
}
mod.AssureStringPtrPtr(&spec.OwnerId, p)
mod.AssureInt64PtrPtr(&spec.TTL, info.TTL)
if !reflect.DeepEqual(spec.RoutingPolicy, info.RoutingPolicy) {
spec.RoutingPolicy = info.RoutingPolicy
mod.Modify(true)
}
mod.AssureInt64PtrPtr(&spec.CNameLookupInterval, info.Interval)
targets := info.Targets
text := info.Text
this.mapRef(obj, info)
if info.TargetRef != nil {
if spec.Reference == nil ||
spec.Reference.Name != info.TargetRef.Name || spec.Reference.Namespace != info.TargetRef.Namespace {
spec.Reference = info.TargetRef
targets = nil
text = nil
mod.Modify(true)
}
} else {
if spec.Reference != nil {
spec.Reference = nil
mod.Modify(true)
}
}
if len(targets) > 0 || len(text) > 0 || !ignoreEmptyTargets(obj) {
mod.AssureStringSet(&spec.Targets, targets)
mod.AssureStringSet(&spec.Text, text)
} else if len(spec.Targets) > 0 && ignoreEmptyTargets(obj) {
// keep old targets if load balancer disappears temporarily
logger.Infof("ignoring empty targets for entry %s", slave.ObjectName())
}
if info.IPStack != "" {
annots := o.GetAnnotations()
if annots == nil {
annots = map[string]string{}
}
if annots[dns.AnnotationIPStack] != info.IPStack {
annots[dns.AnnotationIPStack] = info.IPStack
o.SetAnnotations(annots)
mod.Modify(true)
}
} else {
if o.GetAnnotations()[dns.AnnotationIPStack] != "" {
annots := o.GetAnnotations()
delete(annots, dns.AnnotationIPStack)
o.SetAnnotations(annots)
mod.Modify(true)
}
}
if mod.IsModified() {
logger.Infof("update entry %s", slave.ObjectName())
}
return mod.IsModified(), nil
}
return slave.Modify(f)
}
func (this *sourceReconciler) deleteEntry(logger logger.LogContext, e resources.Object, name dns.DNSSetName, feedback DNSFeedback) error {
err := e.Delete()
if err == nil {
msg := fmt.Sprintf("deleted dns entry object %s", e.ObjectName())
if feedback != nil {
feedback.Deleted(logger, name.String(), msg)
} else {
logger.Info(msg)
}
} else {
if !errors.IsNotFound(err) {
logger.Errorf("cannot delete dns entry object %s: %s", e.ObjectName(), err)
} else {
err = nil
}
}
return err
}
func ignoreEmptyTargets(obj resources.Object) bool {
_, ok := obj.Data().(*api.DNSEntry)
return !ok
}