Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read new .spec.pools[].userDataSecretRef field for worker pool user data #727

Merged
merged 3 commits into from
May 23, 2024
Merged

Read new .spec.pools[].userDataSecretRef field for worker pool user data #727

merged 3 commits into from
May 23, 2024

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area scalability
/kind enhancement

What this PR does / why we need it:
This extension now makes use of the new .spec.pools[].userDataSecretRef field (introduced with gardener/gardener#9722 and available from gardener/gardener@v1.95+) to get to the worker pool user data.
Similar to gardener/gardener@6132277

Which issue(s) this PR fixes:
Part of gardener/gardener#9545

Special notes for your reviewer:
/cc @kon-angelo

Release note:

This extension now makes use of the new `.spec.pools[].userDataSecretRef` field to get to the worker pool user data.

@rfranzke rfranzke requested review from a team as code owners May 22, 2024 13:16
@gardener-robot gardener-robot added needs/review Needs review area/scalability Scalability related kind/enhancement Enhancement, improvement, extension size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2024
@rfranzke
Copy link
Member Author

/cc @shaoyongfeng @EmoinLanyu @jia-jerry @kevin-lacoo

@rfranzke rfranzke mentioned this pull request May 22, 2024
Closed
8 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 22, 2024
kon-angelo
kon-angelo approved these changes May 22, 2024
View reviewed changes
Copy link

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2024
@shaoyongfeng shaoyongfeng merged commit 55cfa27 into gardener:master May 23, 2024
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 23, 2024
@rfranzke rfranzke deleted the userdata-secret-ref branch May 23, 2024 07:24
@rfranzke rfranzke mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/scalability Scalability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @shaoyongfeng @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot