-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove server group update validation #212
Merged
dkistner
merged 1 commit into
gardener:master
from
kon-angelo:allow-servergroups-to-update
Jan 26, 2021
Merged
remove server group update validation #212
dkistner
merged 1 commit into
gardener:master
from
kon-angelo:allow-servergroups-to-update
Jan 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
Control plane related
kind/enhancement
Enhancement, improvement, extension
platform/openstack
OpenStack platform/infrastructure
priority/normal
needs/review
Needs review
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Jan 25, 2021
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 25, 2021
Could you add a Furthermore we should add documentation for that with a bold hint of the rolling update. |
kon-angelo
force-pushed
the
allow-servergroups-to-update
branch
from
January 25, 2021 14:49
5ca8043
to
69a60ba
Compare
gardener-robot
added
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
and removed
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Jan 25, 2021
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 25, 2021
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 25, 2021
Why is it a |
Sorry didn't mean |
I will remove the draft, once documentation is also updated. |
kon-angelo
force-pushed
the
allow-servergroups-to-update
branch
from
January 25, 2021 17:25
69a60ba
to
cd71fa0
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 25, 2021
dkistner
approved these changes
Jan 26, 2021
gardener-robot
added
priority/3
Priority (lower number equals higher priority)
and removed
priority/3
Priority (lower number equals higher priority)
labels
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
platform/openstack
OpenStack platform/infrastructure
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
/platform openstack
What this PR does / why we need it:
This PR removes the validation checks that prevented worker groups to change server group settings after their creation. This will trigger a rolling update (by changing the
MachineClass
hash)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: