Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove server group update validation #212

Merged
merged 1 commit into from
Jan 26, 2021
Merged

remove server group update validation #212

merged 1 commit into from
Jan 26, 2021

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Jan 25, 2021 •
edited

How to categorize this PR?

/area control-plane
/kind enhancement
/priority normal
/platform openstack

What this PR does / why we need it:
This PR removes the validation checks that prevented worker groups to change server group settings after their creation. This will trigger a rolling update (by changing the MachineClass hash)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Allow updating server group settings on existing worker groups.

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure priority/normal needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 25, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 25, 2021
@dkistner
Copy link
Member

Could you add a breaking user release note with a hint for user that changing the server group policy will lead to rolling update of the worker pool.

Furthermore we should add documentation for that with a bold hint of the rolling update.

@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 25, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2021
@rfranzke
Copy link
Member

Why is it a breaking change @dkistner ?

@dkistner
Copy link
Member

Sorry didn't mean breaking rather doc to make it prominent for users.

@kon-angelo
Copy link
Contributor Author

I will remove the draft, once documentation is also updated.

@kon-angelo kon-angelo marked this pull request as ready for review January 25, 2021 17:25
@kon-angelo kon-angelo requested review from a team as code owners January 25, 2021 17:25
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 25, 2021
@dkistner dkistner merged commit fe7dc92 into gardener:master Jan 26, 2021
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/openstack OpenStack platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kon-angelo @dkistner @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot