Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for developers #81

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Add docs for developers #81

merged 4 commits into from
Nov 9, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Oct 25, 2023 •
edited
Loading

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
The PR adds documentation for developers.

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Oct 25, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@ialidzhikov ialidzhikov mentioned this pull request Oct 25, 2023
Closed
96 tasks
@dimitar-kostadinov
Copy link
Contributor

/retest

1 similar comment
@dimitar-kostadinov
Copy link
Contributor

/retest

@ialidzhikov
Copy link
Member Author

I created #82 for the failure in https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener-extension-registry-cache/81/pull-gardener-extension-registry-cache-e2e-kind/1717128016045281280.

@ialidzhikov
Copy link
Member Author

/test pull-gardener-extension-registry-cache-publish-test-images

@ialidzhikov
Copy link
Member Author

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
plkokanov
plkokanov suggested changes Nov 2, 2023
View reviewed changes
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits

docs/development/extension-registry-cache.md Outdated Show resolved Hide resolved
docs/development/extension-registry-cache.md Outdated Show resolved Hide resolved
dimitar-kostadinov
dimitar-kostadinov reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 9, 2023

LGTM label has been added.

Git tree hash: c8e2232c177d3a11379b7e74fbd7eac776104a78

@gardener-prow gardener-prow bot merged commit 944f45f into gardener:main Nov 9, 2023
6 checks passed
@ialidzhikov ialidzhikov deleted the enh/developer-docs branch November 10, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov left review comments

@rfranzke rfranzke Awaiting requested review from rfranzke

@plkokanov plkokanov Awaiting requested review from plkokanov

Assignees

@plkokanov plkokanov

@dimitar-kostadinov dimitar-kostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialidzhikov @dimitar-kostadinov @plkokanov