Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme and fix naming for garden_shoot_node_info #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update readme and fix naming for garden_shoot_node_info #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbde8d8
remove duplicate metric from readme
Sinscerly Apr 24, 2024
6ee9fd6
Rename `garden_shoot_node_info` to `garden_shoot_worker_node_info`.
Sinscerly Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ The `gardener-metrics-exporter` is a [Prometheus][] metrics exporter for
| garden_shoot_operation_states | Operation state of a Shoot | Shoot | Gauge |
| garden_shoot_info | Information to a Shoot | Shoot | Gauge |
| garden_shoot_condition | Condition state of a Shoot | Shoot | Gauge |
| garden_shoot_worker_node_info | Node information of a Shoot worker group | Shoot | Gauge |
| garden_shoot_node_min_total | Min node count of a Shoot | Shoot | Gauge |
| garden_shoot_node_max_total | Max node count of a Shoot | Shoot | Gauge |
| garden_shoot_worker_node_min_total | Min node count of a Shoot worker group | Shoot | Gauge |
| garden_shoot_worker_node_max_total | Max node count of a Shoot worker group | Shoot | Gauge |
| garden_shoot_operations_total | Count of ongoing operations | Shoot | Gauge |
| garden_shoot_operation_states | Operation State of a Shoot | Shoot | Gauge |
| garden_shoot_operation_progress_percent | Operation Percentage of a Shoot | Shoot | Gauge |
| garden_seed_info | Information to a Seed | Seed | Gauge |
| garden_seed_capacity | Information regarding a seed's capacity with respect to certain resources | Seed | Gauge |
Expand Down
6 changes: 3 additions & 3 deletions pkg/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,9 @@ func getGardenMetricsDefinitions() map[string]*prometheus.Desc {
nil,
),

metricGardenShootNodeInfo: prometheus.NewDesc(
metricGardenShootNodeInfo,
"Information about the nodes in a Shoot.",
metricGardenShootWorkerNodeInfo: prometheus.NewDesc(
metricGardenShootWorkerNodeInfo,
"Information about the worker group nodes in a Shoot.",
[]string{
"name",
"project",
Expand Down
2 changes: 1 addition & 1 deletion pkg/metrics/shoot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ func (c gardenMetricsCollector) collectShootNodeMetrics(shoot *gardenv1beta1.Sho

// Expose metrics about the Shoot's nodes.
metric, err = prometheus.NewConstMetric(
c.descs[metricGardenShootNodeInfo],
c.descs[metricGardenShootWorkerNodeInfo],
prometheus.GaugeValue,
0,
[]string{
Expand Down
4 changes: 2 additions & 2 deletions pkg/metrics/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ const (
metricGardenShootWorkerNodeMinTotal = "garden_shoot_worker_node_min_total"

// Aggregated Shoot metrics (exclude Shoots which act as Seed).
metricGardenOperationsTotal = "garden_shoot_operations_total"
metricGardenShootNodeInfo = "garden_shoot_node_info"
metricGardenOperationsTotal = "garden_shoot_operations_total"
metricGardenShootWorkerNodeInfo = "garden_shoot_worker_node_info"
)