Remove etcd proposal alerts. #10524
Merged
Remove etcd proposal alerts. #10524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
requested review from
ashwani2k,
shreyas-s-rao and
vicwicker
gardener-prow
bot
added
area/monitoring
|
@rickardsjp @vicwicker could you take a look? |
|
/lgtm, thank you! |
|
LGTM label has been added. Git tree hash: 744d34851a12a8f7d4958d4132cace12be255a7d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind cleanup
What this PR does / why we need it:
Removes alerts which are built on the
proposals_failed_totalmetric of etcd.The information that these alerts currently convey are already conveyed to the operator through other means, and there is no action an operator can take to fix the issue that raises these alerts (primarily leader election among members of the etcd cluster). See #10514 for more information.
Which issue(s) this PR fixes:
Fixes #10514
Special notes for your reviewer:
/cc @shreyas-s-rao @ashwani2k @vicwicker @rickardsjp
Release note: