-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condition transitions False->Progressing on reason/message change #3013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Any further opinions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, TBH I'm not completely sure about the implications of this change.
I think, we need a bit more sophisticated logic here, unfortunately.
WDYT?
/status author-action |
@rfranzke The pull request was assigned to you under |
c410b1f
to
a4ae67f
Compare
/unassign Incorporated feedback from @timebertt to only react on changes of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
How to categorize this PR?
/area ops-productivity
/kind enhancement
/priority normal
What this PR does / why we need it:
Failed conditions on
Shoot
s do now transition fromFalse
status toProgressing
in case the reason or message changes (if thresholds are defined in the gardenlet component config only, otherwiseProgressing
is not used anyways).This will improve ops productivity as a condition will no longer stay
False
for a long time although different errors are happening subsequently.Special notes for your reviewer:
/cc @timuthy
Release note: