Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore NodeFeature:RuntimeHandler tests #361

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Ignore NodeFeature:RuntimeHandler tests #361

merged 1 commit into from
Aug 4, 2021

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Aug 4, 2021

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
When enabling containerd for the k8s e2e tests, we stumbled upon gardener/gardener#4458: this test would require a special containerd configuration to succeed. The feature itself is used e.g. for enabling gVisor and also tested there: https://github.com/gardener/gardener-extension-runtime-gvisor/blob/b7cb2d5a85de903def803f3db5500fea110b79a6/test/integration/container-runtime/container_runtime.go#L40

Which issue(s) this PR fixes:
Fixes gardener/gardener#4458

Special notes for your reviewer:

Release note:

Skip `[sig-node] RuntimeClass should run a Pod requesting a RuntimeClass with a configured handler [NodeFeature:RuntimeHandler]`, as it requires special test configuration for `containerd` to succeed.

@voelzmo voelzmo requested a review from a team as a code owner August 4, 2021 13:25
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 4, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 4, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2021
@voelzmo voelzmo mentioned this pull request Aug 4, 2021
Closed
31 tasks
dguendisch
dguendisch approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 4, 2021
@dguendisch dguendisch merged commit ea19a1a into gardener:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky Test] FLAKING e2e-fast/NodeFeature:RuntimeHandler
5 participants
@voelzmo @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot