-
Notifications
You must be signed in to change notification settings - Fork 2
*.py files migrated from gardenlinux workflows #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
da3abe6
06b2f69
234cad8
332329d
3ad7a9e
df1c1eb
2ec4e57
a3419b7
4dc00f5
7011313
bfd7fa7
ff7965f
70b2231
a1527ed
c2c5d05
ab770f6
3cd9870
f00621b
72d2f6f
5cdd443
821efcf
23a8a14
3c292e7
eed5ba0
355860b
114af49
85efed3
2d46645
7e89bd9
895c87e
e8f171d
0c40e02
6981bca
cf7fca2
104b7ea
b268216
5fa5d04
7587e26
b18747f
b0abc3a
23dd7cf
17488b9
d42eac8
08f0a6e
535e6de
a3437c1
8613416
3cc6051
f417b28
5b657d6
4b0fcb1
587faea
943e2d3
fa6e7f8
de948ab
a243406
5de40e1
932fa28
1c948c7
e22a7bb
0ea4100
3e00c6c
721a013
601ca8c
c99b904
1c55079
83fae37
f789749
b22f349
e8201bd
616321d
7b0699c
c9baa93
48fc0c4
74e3ca1
233613d
201f372
7dbbe20
54a2f5d
1c58f8d
ddf2116
5e79b3c
a24966c
4b4bfba
fd4991c
e7fdcce
5d1a585
f43ff13
2583ffc
b9b3851
4702fb7
86c8195
7cc833a
12df7e8
6ba9dbf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,3 +169,4 @@ bandit-report.json | |
|
||
# zot | ||
test-data/zot | ||
s3_downloads/ |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
from .__main__ import create_github_release_notes | ||
|
||
__all__ = ["create_github_release_notes"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMHO there's no reason to export this function. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In my opinion calling gardenlinux.github.create_github_release_notes looks much better than gardenlinux.github.main.create_github_release_notes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While I do agree in general you won't call |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file needs refactoring. There are too many generic / helper functions doing various things needed for later release content creation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Although I agree with that, it's not the focus of this PR. Let's first move the code away from the main gardenlinux repo, release the 0.10.0 and then improve or refactor it step-by-step in 0.10.x versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of this parameter? is this a temporary thing for development or a permanent thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can specify which
python-gardenlinux-lib
to install using theversion
input parameter for.github/actions/setup
. While this has advantages to select a known tested/working version for execution I do not see an benefit adding it toflavors_parse
or ''features_parse` GitHub actions as they provide an encapsulated result (matrix or GL canonical name) for example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you mean by encapsulated result. flavors_parse action installs python-gardenlinux-lib. I've added version input for all actions that install this library, because otherwise the version of the library is tied to the version of CI workflow code and I think these concerns should not be mixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the version here. Don't see an benefit with parametrizing it here.