Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postInteractionWait does not work anymore on v6.1.1 (puppeteer) #1431

Closed
ttl15 opened this issue Aug 8, 2022 · 2 comments
Closed

postInteractionWait does not work anymore on v6.1.1 (puppeteer) #1431

ttl15 opened this issue Aug 8, 2022 · 2 comments

Comments

@ttl15
Copy link

ttl15 commented Aug 8, 2022

Hello,

Looks like v6.1.1 update
"puppeteer": "^14.2.1",
to
"puppeteer": "^15.4.0",

when postInteractionWait on backstop.json file is greater than 0 (ie 3000)

backstop will throw an error below

Puppeteer encountered an error while running scenario...
TypeError: page.waitFor is not a function

steps to reproduce

use backstop v6.1.1
create a new project
backstop init
backstop reference

no errors so far

now change postInteractionWait in backstop.json file to something other than 0 (ie 3000)
run backstop reference again

error msg

SCENARIO > BackstopJS Homepage
Puppeteer encountered an error while running scenario "BackstopJS Homepage"
TypeError: page.waitFor is not a function
Browser Console Log 0: JSHandle:BackstopTools have been installed.
SCENARIO > BackstopJS Homepage
Puppeteer encountered an error while running scenario "BackstopJS Homepage"
TypeError: page.waitFor is not a function
@ttl15 ttl15 changed the title postInteractionWait does not work anymore on v6.1.1 postInteractionWait does not work anymore on v6.1.1 (puppeteer) Aug 8, 2022
@darby3
Copy link
Contributor

darby3 commented Aug 22, 2022

FWIW rolling back to backstopjs 6.1.0 got me around this. Saw this in the log output:

waitFor is deprecated and will be removed in a future release. See https://github.com/puppeteer/puppeteer/issues/6214 for details and how to migrate your code.

@flosell
Copy link
Contributor

flosell commented Oct 9, 2022

For those running into the issue and finding this issue - there's now a PR to fix this (#1441) but you might need to fix this yourself if you have a puppet/clientAndHoverHelper.js generated by a previous version of backstop.

Have a look here for inspiration.

@garris garris closed this as completed in 1018f68 Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants