Remove usage of deprecated/removed waitFor in clickAndHoverHelper scripts #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garris
approved these changes
Oct 9, 2022
|
This is great. Thank you! |
giorgiosironi
added a commit
to sciety/sciety
that referenced
this pull request
Nov 8, 2022
For context garris/BackstopJS#1441 which says we need to maintain this ourselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppeteer deprecated and by now, removed
page.waitFor()(see puppeteer/puppeteer#6214). This results inTypeError: page.waitFor is not a functionwhen using things likepostInteractionWait,clickSelectorand similar features relying onclickAndHoverHelper.js. See #1431 for details.You can observe this issue when running
npm run smoke-test:This PR fixes all usage of
waitForin examples, tests and templates used forbackstop init.Projects that ran
backstop initwould still need to change their version of the scripts themselves but at least for new usages, this issue would be fixed (and existing users would have a guide what a fixed version would look like)(by the way, it's Hacktoberfest so consider opting in by adding a
hacktoberfesttopic to the repo before merging PRs to give contributors a chance for a tiny reward 😄 )