Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] tutorial/part-zero #8

Merged
merged 1 commit into from
Jan 3, 2020
Merged

[Translation] tutorial/part-zero #8

merged 1 commit into from
Jan 3, 2020

Conversation

vitokhangnguyen
Copy link
Contributor

I also adjusted some translation for tutorial/index

@vitokhangnguyen
Copy link
Contributor Author

@giatuongtran9 If you have time and are willing to, please help me review this PR. No pressure!

Copy link
Contributor

@giatuongtran9 giatuongtran9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just my recommendation.If you find it not ok, you don't need to replace it.

docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-zero/index.md Outdated Show resolved Hide resolved
@gatsbybot gatsbybot mentioned this pull request Nov 30, 2019
46 tasks
@vitokhangnguyen
Copy link
Contributor Author

@giatuongtran9 Cám ơn bạn đã dành tời gian review qua PR của mình. Mình không thấy notification nên reply hơi trễ, rãnh mình sẽ update PR,

giatuongtran9
giatuongtran9 previously approved these changes Dec 19, 2019
Copy link
Contributor

@giatuongtran9 giatuongtran9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Adjust translation for tutorial/index
@vitokhangnguyen vitokhangnguyen merged commit 99975f2 into master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants