Skip to content

Commit 36357ab

Browse files
authored
fix(gatsby): add explicit dependency on socket.io-client and explicitly set url-loader fallback (#24465)
* provide fully qualified path for url-loader's `fallback` * create resolution for `socket.io-client`, for import in `.cache/app.js` * include socket.io-client as dependency
1 parent 31147ff commit 36357ab

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

packages/gatsby/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132
"signal-exit": "^3.0.3",
133133
"slugify": "^1.4.0",
134134
"socket.io": "^2.3.0",
135+
"socket.io-client": "2.3.0",
135136
"stack-trace": "^0.0.10",
136137
"string-similarity": "^1.2.2",
137138
"style-loader": "^0.23.1",

packages/gatsby/src/utils/webpack-utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ export const createWebpackUtils = (
250250
options: {
251251
limit: 10000,
252252
name: `${assetRelativeRoot}[name]-[hash].[ext]`,
253+
fallback: require.resolve(`file-loader`),
253254
...options,
254255
},
255256
}

packages/gatsby/src/utils/webpack.config.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,9 @@ module.exports = async (
404404
"@pmmmwh/react-refresh-webpack-plugin": path.dirname(
405405
require.resolve(`@pmmmwh/react-refresh-webpack-plugin/package.json`)
406406
),
407+
"socket.io-client": path.dirname(
408+
require.resolve(`socket.io-client/package.json`)
409+
),
407410
},
408411
plugins: [
409412
// Those two folders are special and contain gatsby-generated files

0 commit comments

Comments
 (0)