-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatsby v2.13.65 -> v2.13.66 introduces a lot of warnings in Windows due to path changes #16721
Comments
@waltercruz Did you see this issue? Thanks. |
I will check it out! |
See this comment. tl;dr: use powershell |
Hi @karland , have you seen @caseyWebb comment? I still can implement his last suggestion, "Gatsby could always enforce/assume uppercase drive letters when checking paths", but I will need some more days (don't have access any windows machine to test). |
Hi @waltercruz. Yes, I have seen the excellent and very nice explanation of @caseyWebb. Based on this explanation, I now understand the source of the problem and can now work around it. I still think, however, it would be good in Gatsby internally to always convert Windows drive letters to uppercase to solve this problem for good, but I have no clue how difficult this is. Thanks a lot for your kind offer/help. |
Hey @jannikbuschke , please see this comment. BTW, glad that you remembered of Azure, I will try to use a windows machine there to test. I will fix it in the next days. |
Fix the weird way that windows handles drive letter upper/lower case.
Fix the weird way that windows handles drive letter upper/lower case.
Fixed and published in |
Hello.. so it seems I am still getting a very similar issue. I am on Gatsby version 2.15.29 and Gatsby-CLI version 2.7.54, running on WSL Ubuntu.
The same applies to plugin |
Long history, but it's about windows filesystem and the weird way that windows handles it. See this comment. But long story short, it should not try to uppercase the first letter if it's running on WSL. My code by now just checks if is running on windows, I should probably check if running on WSL and don't fo the uppercase of the first letter. I will create a ticket and assign it to myself, but I will only have time to do it in some days. |
Description
I am on Windows 10. After updating from Gatsby v2.13.65 -> 2.13.66 I get a lot of warnings resulting from the path letter being different, such as this
I believe the error results from cac4246
Up until Gatsby v2.13.65 all path letters were in lower cases, which was good.
I also believe the Windows path letters in packages/gatsby/src/utils/tests/path.js should be lower case.
The text was updated successfully, but these errors were encountered: