Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prev/next links to detail page - starter showcase #6711

Closed
shannonbux opened this issue Jul 24, 2018 · 8 comments
Closed

Add prev/next links to detail page - starter showcase #6711

shannonbux opened this issue Jul 24, 2018 · 8 comments
Assignees

Comments

@shannonbux
Copy link
Contributor

Add prev/next links like we have in Site Showcase

@swyxio
Copy link
Contributor

swyxio commented Jul 26, 2018

well - there are no prev/next links in the design at the moment... what do i do?

@shannonbux
Copy link
Contributor Author

Hi @sw-yx, can you clarify your question?

@swyxio
Copy link
Contributor

swyxio commented Jul 27, 2018

well, check the wireframe:

startershowcasedetail

there's no design for prev/next links...

(again offering personal opinion here - i dont think this is really needed unlike the site showcase so i never raised a question about it)

@shannonbux
Copy link
Contributor Author

shannonbux commented Jul 27, 2018 via email

@swyxio
Copy link
Contributor

swyxio commented Jul 27, 2018

ah. this index navigation issue is something i do care more about. would be fixed when/if you expand the main navigation, but can maybe include a button somewhere

@fk
Copy link
Contributor

fk commented Jul 30, 2018

there's no design for prev/next links...

True, the mockups I made for the starter showcase didn't include those. I never intended them to be understood as full wireframes of the pages in question tho, but to highlight the most significant component changes as compared to the site showcase. But I never didn't communicated that clearly :-/ …still learning, apologies again! 🙏

I always thought prev/next navigation wouldn't be wrong for the starters either; I also assume that much less people will browse starters using them than showcased sites.


Regarding the "navigate back to index page" discussion, this could look like this

image

if we have enough horizontal space (icon is MdArrowBack), and that link could be preceiding the site/starter title like this for smaller screens:

image

(screenshot from the site showcase mobile prototype).

To really make that work for smaller screens, I think it's best to move the starter author name below the starter title -- we could just re-use the "Built by" bit of the site showcase detail view:

image

Will working on consolidating site and starter showcase headers now (#6710, #6098).

@amberleyromo
Copy link
Contributor

@fk @shannonbux if i'm reading all this correctly, did this all end with no pagination needed? just back to the starter showcase? if so, let's close, deferring to #6710

@shannonbux
Copy link
Contributor Author

Yes, Amberley, closing for now. Might do this in 2.0 Starter Showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants